Compiler Warning: unreachable pattern

[bjoernQ]

warning: unreachable pattern
   --> C:\projects\esp\esp-hal\esp-hal-common\src\sha.rs:295:13
    |
295 |             _ => 128,
    |             ^
    |
    = note: `#[warn(unreachable_patterns)]` on by default

[i404788]

Depends on the chip used I think, I think it's only for chips not supporting larger SHA implementations (C series iirc), could add a cfg macro for that path.

[jessebraham]

Yeah sorry, I was aware of this and let it through anyways. Just affecting the C-series sounds correct to me.

[bjoernQ]

No problem - I'd be even fine with an #[allow(..)] for that code block - it's just that compiler warnings are somewhat annoying in such a crate