Skip to content

Remove unused files, clean up some #[cfg]s and #[allow] attributes #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

jessebraham
Copy link
Member

  • If we are not providing a .vscode/settings.json file anymore, no reason to keep .vscode/extensions.json
  • It's quite clear people aren't using the pre-commit hook, so I'm removing it
    • I removed the blurb about it from README.md awhile back for this reason, but apparently forgot to remove this file
  • Clean up some #[cfg]s and #[allow] attributes

@jessebraham jessebraham added the skip-changelog No changelog modification needed label Apr 22, 2024
@@ -982,7 +974,11 @@ where
.uart1_sclk_div_num()
.bits(clk_div as u8 - 1)
.uart1_sclk_sel()
.bits(0x3) // TODO: this probably shouldn't be hard-coded
.bits(match clock_source {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MabezDev MabezDev added this pull request to the merge queue Apr 22, 2024
Merged via the queue into esp-rs:main with commit c438319 Apr 22, 2024
@jessebraham jessebraham deleted the fixes/misc branch April 22, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog No changelog modification needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants