-
Notifications
You must be signed in to change notification settings - Fork 296
Add support for the ESP32-C2/ESP8684 #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add a feature for the ESP32-C2 to`esp-hal-common` and update some `cfg`s Organize the `esp-hal-common` imports and exports and update to include the ESP32-C2
Only a few left still to add
Note that this example still doesn't seem to be working correctly
There are a couple of unused constants in |
Besides the things mentioned above this already looks good to me. For I2C we could also note it's not working yet and deactivate the example until we figure out what is wrong |
Oops, meant to remove those and forgot. Thanks for pointing it out, they're gone now.
I'll spend a bit of time today looking into the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot to unpack here, I mainly focused on the linker scripts which look fine to me! Everything else seems to be clock control or glue code into existing drivers.
Yay for C2 support! 🎉
The issues with |
Apologies for the size of this PR 😁
As per the title, adds support for the ESP32-C2/ESP8684. The SVD/PAC are still missing a peripheral or two (I think it's just
LEDC
but I could have missed more), but this covers most of the hardware.The
i2c_display
example has not been tested, as I don't have this display. @bjoernQ can you please try it out? I have tested all of the remaining examples and their behaviour is consistent with the other devices. This has not been thoroughly tested, however.The CI config is still a bit janky and will need to be fixed eventually, but it works for now so I'm not going to worry about it.
This has been rebased a number of times, so there may be some artifacts from that. I think I've caught them all, but something to keep in mind.