Update esp-hal-common to use the newest PACs
#215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Code looks fine to me and I did smoke tests on all the supported chips (i.e. run all examples that don't need much additional hardware attached) Good job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've overhauled the SVD generator, so there are a number of changes which make the SVDs more correct. More specifically I've also added the
SENSperipheral to the ESP32-S3, so we can finally implementADCfor it.There is also the chance of some regressions, but I've reviewed the changes the best I can and am reasonably confident we're in okay shape.
svd2rustnow usescritical-sectioninstead ofbare-metalandinterrupt::freeso the new PACs do this as well. This unfortunately introduced a warning for the ESP32-C2/C3, however it has been fixed already so with the next release ofsvd2rustwe can eliminate these.I have not actually tested any examples on hardware yet which is why this is marked as draft. I'm going to test a bunch just to try and be reasonably sure I haven't horribly broken anything.