Installer improvements #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @SergioGasquez for the contribution. It's always good to optimize development process. The change require additional testing. I suggest to include it with 1.62.0.0 build. I've market the PR with the milestone. |
|
Changes looks good. We should be careful about minimal profile, we need to check tests whether examples are building without problem. |
georgik
added a commit
that referenced
this pull request
Jul 13, 2022
* ci: update version to 1.62.0.0 * Installer improvements (#88) * Use nightly toolchain with profile-minimal * Install llvm clang only for Xtensa targets * Add cargo-generate url and bin file for aarch64-unknown-linux-gnu (#89) * Support `--build-target all` (#92) * Fix ldproxy links (#94) * ci: add system package dependency on openssl * Remove PIP_USER (#96) * Remove espmonitor (#99) - replaced by functionality in espflash * Add `ldproxy` binary for `aarch64-unknown-linux-gnu` (#100) * Update espflash and cargo-espflash binaries (#103) * Fix: Use cargo-espflash binary (#105) Co-authored-by: Sergio Gasquez Arcos <[email protected]>
|
Additionally, the install script is still adding the GCC bin path to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install_rustnightlytoolchain for Xtensa targets, instead ofstableandnightlyas is sufficientCloses #72