Skip to content

Use the installation script from a release instead of the main branch #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

jessebraham
Copy link
Member

This is being left as a draft until I can confirm that it is a viable path forward.

Rather than pulling the installation script from the main branch of rust-build, we will now use the script provided in the release corresponding to the specified compiler version.

In order for this to work a couple things must hold true:

@georgik @SergioGasquez please let me know what you think of this.

Closes #7.

Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think the two conditions required for this to work are entirely accepted. Even more, in the future, we should be able to remove the prereleases of MinGW and LLVM

@jessebraham jessebraham marked this pull request as ready for review September 6, 2022 17:16
@jessebraham jessebraham merged commit dc1d465 into esp-rs:main Sep 6, 2022
@jessebraham jessebraham deleted the fixes/release-scripts branch September 14, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation script should be downloaded from a release, not the main branch
2 participants