Prevent rewriting core_version.h if content unchanged #6414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@d-a-v According to history, you're the commiter of previous changes to this file, could you please review? |
devyte
approved these changes
Aug 12, 2019
earlephilhower
approved these changes
Aug 12, 2019
mcspr
added a commit
to mcspr/esp8266-Arduino
that referenced
this pull request
May 27, 2025
update packaging script w/ new arguments rewrite ci build pattern to only rewrite core_version.h once per job restore behaviour from esp8266#6414 for other cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR compares old and new and suppresses file writing if nothing changes.
This stops builds from oscillating between 5s and 20s, when there is NO change to the core and "core libraries".