Decreasing SPIFFS partition size by 4 bytes to workaround issue #7467

[CoryCharlton]

Description of Change

Decreasing SPIFFS partition size by 1KB to workaround issue #7467

Tests scenarios

Tested with PIO using Arduino Core v2.0.5 using an Unexpected Maker FeatherS3

Related links

Works around #7467

[CLAassistant]

All committers have signed the CLA.

[BlueAndi]

@SuGlider, @CoryCharlton The 4 byte less corresponds in a filesystem which is not 4 k aligned. Did you try an OTA update of the filesystem?

arduino-esp32/libraries/Update/src/Updater.cpp

Lines 153 to 158 in 972c3bb

	if(size == UPDATE_SIZE_UNKNOWN){
	size = _partition->size;
	} else if(size > _partition->size){
	_error = UPDATE_ERROR_SIZE;
	log_e("too large %u > %u", size, _partition->size);
	return false;

arduino-esp32/libraries/Update/src/Updater.cpp

Lines 207 to 215 in 972c3bb

	bool block_erase = (_size - _progress >= SPI_FLASH_BLOCK_SIZE) && (offset % SPI_FLASH_BLOCK_SIZE == 0); // if it's the block boundary, than erase the whole block from here
	bool part_head_sectors = _partition->address % SPI_FLASH_BLOCK_SIZE && offset < (_partition->address / SPI_FLASH_BLOCK_SIZE + 1) * SPI_FLASH_BLOCK_SIZE; // sector belong to unaligned partition heading block
	bool part_tail_sectors = offset >= (_partition->address + _size) / SPI_FLASH_BLOCK_SIZE * SPI_FLASH_BLOCK_SIZE; // sector belong to unaligned partition tailing block
	if (block_erase || part_head_sectors || part_tail_sectors){
	if(!ESP.partitionEraseRange(_partition, _progress, block_erase ? SPI_FLASH_BLOCK_SIZE : SPI_FLASH_SEC_SIZE)){
	_abort(UPDATE_ERROR_ERASE);
	return false;
	}
	}

arduino-esp32/libraries/Update/src/Update.h

Line 32 in 972c3bb

#define SPI_FLASH_BLOCK_SIZE (SPI_SECTORS_PER_BLOCK*SPI_FLASH_SEC_SIZE)

Means this must be considered:

#define SPI_FLASH_SEC_SIZE  4096    /**< SPI Flash sector size */

[Jason2866]

Is this still needed with the change/fix of esptool commit? https://github.com/espressif/esptool/tree/21e59148e73e384947327a0883a753685e03d143

[SuGlider]

Is this still needed with the change/fix of esptool commit? https://github.com/espressif/esptool/tree/21e59148e73e384947327a0883a753685e03d143

I think that it may have fixed the issue reported by @CoryCharlton
@CoryCharlton - could you please test the latest version of esptool to check if the issue you reported is solved?
Thanks.

[SuGlider]

@me-no-dev - not sure how this fix to esptool may be reflected into the Arduino Core tools.
Would it be necessary to update some files?

[me-no-dev]

@SuGlider this fix needs to be released from esptool team and then we can try to update it for Arduino

[Jason2866]

@me-no-dev Not using Arduino IDE so maybe a total dumb question. Why not using esptool.py directly? You are using in Arduino Lib Builder components from latest master branch to build the libs. Why not doing for esptool.py too?

[CoryCharlton]

I think that it may have fixed the issue reported by @CoryCharlton
@CoryCharlton - could you please test the latest version of esptool to check if the issue you reported is solved?
Thanks.

Confirmed that this change resolves the issue. Closing this PR and will close the issue.

[me-no-dev]

@me-no-dev Not using Arduino IDE so maybe a total dumb question. Why not using esptool.py directly? You are using in Arduino Lib Builder components from latest master branch to build the libs. Why not doing for esptool.py too?

we pull esptool when released (or when it's necessary), but in this case, the change that fixes this issue is not part of any released esptool yet. We can not use the one in ESP-IDF, because for Windows and Mac we need the compiled versions (which are part of the releases of esptool)