feat(button): matrix with inverted row scan levels (AEGHB-1005) #480
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends button matrix with inverted levels (low pulse) for the row scan. It introduces a new flag
scan_inverted
inbutton_matrix_config_t
that controls this behaviour.Button matrix hardware variants with blocking diode cathodes on the row GPIOs require a low pulse on the currently scanned row and a pull-up resistor on the column GPIOs. The current button matrix implementation uses a high pulse on the row GPIO, which only works for the described hardware variant if row and column GPIOs are swapped (i. e. hardware rows become software columns and vice versa).