Skip to content

feat(button): matrix with inverted row scan levels (AEGHB-1005) #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chschu
Copy link
Contributor

@chschu chschu commented Mar 11, 2025

This PR extends button matrix with inverted levels (low pulse) for the row scan. It introduces a new flag scan_inverted in button_matrix_config_t that controls this behaviour.

Button matrix hardware variants with blocking diode cathodes on the row GPIOs require a low pulse on the currently scanned row and a pull-up resistor on the column GPIOs. The current button matrix implementation uses a high pulse on the row GPIO, which only works for the described hardware variant if row and column GPIOs are swapped (i. e. hardware rows become software columns and vice versa).

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@CLAassistant
Copy link

CLAassistant commented Mar 11, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello chschu, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 33d9ee8

@github-actions github-actions bot changed the title feat(button): matrix with inverted row scan levels feat(button): matrix with inverted row scan levels (AEGHB-1005) Mar 11, 2025
@leeebo leeebo added the button label Mar 12, 2025
@lijunru-hub
Copy link
Contributor

Could you provide the circuit schematic for your matrix keyboard?

@chschu
Copy link
Contributor Author

chschu commented Mar 13, 2025

@lijunru-hub sure, here it is:

image

The diodes are added to prevent ghosting when pushing multiple buttons.

@lijunru-hub
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants