Skip to content

Add traxmem helpers #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025
Merged

Add traxmem helpers #12

merged 1 commit into from
May 22, 2025

Conversation

erhankur
Copy link
Collaborator

@erhankur erhankur commented May 5, 2025

  • Add Xtensa TRAX memory helpers to be used in the AppTrace module of the OpenOCD stub.
  • Add soc_utils.h private to the library codes.
  • Add bit_utils.h public to the library and client codes.

Will be merged after #11

@erhankur erhankur requested a review from antmak May 5, 2025 15:54
Copy link

github-actions bot commented May 5, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello erhankur, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 3c8a527

@erhankur
Copy link
Collaborator Author

erhankur commented May 5, 2025

@antmak structure is close to your suggestion now. soc_utils.h taken from the #9 PTAL

@erhankur erhankur force-pushed the add_traxmem_helpers branch 3 times, most recently from 09379cf to f4f78b4 Compare May 6, 2025 08:55
@erhankur erhankur force-pushed the add_traxmem_helpers branch from f4f78b4 to 2d61032 Compare May 6, 2025 14:40
@antmak
Copy link
Collaborator

antmak commented May 7, 2025

LGTM, thank you Erhan!

@antmak antmak self-requested a review May 7, 2025 02:12
Copy link
Collaborator

@antmak antmak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@antmak antmak requested a review from gerekon May 8, 2025 11:05
@erhankur erhankur force-pushed the add_traxmem_helpers branch from 2d61032 to 4fc2979 Compare May 12, 2025 05:58
@erhankur erhankur force-pushed the add_traxmem_helpers branch from 4fc2979 to 3c8a527 Compare May 12, 2025 06:05
@erhankur erhankur merged commit c4a2aaf into master May 22, 2025
24 checks passed
@dobairoland dobairoland deleted the add_traxmem_helpers branch June 4, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants