Skip to content

refactor: move target interface to /include/target/ #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025

Conversation

antmak
Copy link
Collaborator

@antmak antmak commented May 7, 2025

merge before #9 please

  • we don't need src/<chip>/include/target/ dir: moved some stuff to src/<chip>/include/soc/
  • include/target/ dir contains target interfaces of subsystems

@antmak antmak requested review from gerekon and erhankur May 7, 2025 09:34
Copy link

github-actions bot commented May 7, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello antmak, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 4d26034

@antmak antmak mentioned this pull request May 7, 2025
Copy link
Collaborator

@erhankur erhankur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment. Otherwise LGTM

@antmak antmak force-pushed the fix/target_structure branch from 82ba404 to fb542f2 Compare May 7, 2025 11:41
@antmak antmak requested a review from erhankur May 7, 2025 13:35
@antmak antmak mentioned this pull request May 7, 2025
@antmak antmak force-pushed the fix/target_structure branch from fb542f2 to 4d26034 Compare May 8, 2025 01:04
@erhankur erhankur merged commit 8de3ec7 into espressif:master May 8, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants