Skip to content

feat(tests): eip7623 - parametrize test_transaction_validity_type_* with a tx to an eoa #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2025
Merged

feat(tests): eip7623 - parametrize test_transaction_validity_type_* with a tx to an eoa #1422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5613bd1
feat(tests): parametrize `test_transaction_validity_type_*` a tx to eoa
danceratopz Apr 9, 2025
4fe5087
fix(tests): use `pre.fund_eoa()` to get valid eoa
danceratopz Apr 11, 2025
0ef04a4
docs: update changelog
danceratopz Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ Test fixtures for use by clients are available for each release on the [Github r

### 🧪 Test Cases

- ✨ Test 7702 precompile case in same transaction as delegation without extra gas in case of precompile code execution; parametrize all call opcodes in existing precompile test ([#1431](https://github.com/ethereum/execution-spec-tests/pull/1431)).
- ✨ [EIP-7702](https://eips.ethereum.org/EIPS/eip-7702): Test precompile case in same transaction as delegation without extra gas in case of precompile code execution; parametrize all call opcodes in existing precompile test ([#1431](https://github.com/ethereum/execution-spec-tests/pull/1431)).
- ✨ [EIP-7623](https://eips.ethereum.org/EIPS/eip-7623): Additionally parametrize transaction validity tests with the `to` set to an EOA account (previously only contracts) ([#1422](https://github.com/ethereum/execution-spec-tests/pull/1422)).

## [v4.2.0](https://github.com/ethereum/execution-spec-tests/releases/tag/v4.2.0) - 2025-04-08

Expand Down
4 changes: 2 additions & 2 deletions tests/prague/eip7623_increase_calldata_cost/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ def to(

if param is None:
return None
if isinstance(param, Address):
return param
if isinstance(param, str) and param == "eoa":
return pre.fund_eoa(amount=0)
if isinstance(param, Bytecode):
return pre.deploy_contract(param)

Expand Down
2 changes: 2 additions & 0 deletions tests/prague/eip7623_increase_calldata_cost/test_transaction_validity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@
@pytest.mark.parametrize(
"to",
[
pytest.param("eoa", id="to_eoa"),
pytest.param(None, id="contract_creating"),
pytest.param(Op.STOP, id=""),
],
Expand All @@ -91,6 +92,7 @@ def test_transaction_validity_type_0(
@pytest.mark.parametrize(
"to",
[
pytest.param("eoa", id="to_eoa"),
pytest.param(None, id="contract_creating"),
pytest.param(Op.STOP, id=""),
],
Expand Down
Loading