-
Notifications
You must be signed in to change notification settings - Fork 146
feat(tests): add more worst-case modexp benchmarks #1701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chfast
wants to merge
1
commit into
ethereum:main
Choose a base branch
from
ipsilon:bench/modexp
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark resultsGeth
Besu
|
marioevz
approved these changes
Jun 2, 2025
#1579 is merged, can now rebase to main and check if everything is still working. |
This refactors the `test_worst_modexp()` with parametrized precompile inputs. It adds inputs consting ~500 gas for the EIP-7883 review.
jsign
approved these changes
Jun 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests/zkevm/test_worst_compute.py::test_worst_modexp[fork_Cancun-blockchain_test_from_state_test-mod_even_32b_exp_40]-1 22858304416
tests/zkevm/test_worst_compute.py::test_worst_modexp[fork_Cancun-blockchain_test_from_state_test-mod_even_32b_exp_96]-1 26373254772
tests/zkevm/test_worst_compute.py::test_worst_modexp[fork_Cancun-blockchain_test_from_state_test-mod_even_32b_exp_256]-1 28089552372
tests/zkevm/test_worst_compute.py::test_worst_modexp[fork_Cancun-blockchain_test_from_state_test-mod_even_24b_exp_168]-1 29398879265
tests/zkevm/test_worst_compute.py::test_worst_modexp[fork_Cancun-blockchain_test_from_state_test-mod_even_16b_exp_320]-1 36480039911
tests/zkevm/test_worst_compute.py::test_worst_modexp[fork_Cancun-blockchain_test_from_state_test-mod_even_8b_exp_896]-1 65149073029
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature:zkevm
scope:tests
Scope: Changes EL client test cases in `./tests`
type:feat
type: Feature
type:refactor
Type: Refactor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ποΈ Description
This refactors the
test_worst_modexp()
with parametrized precompile inputs. It adds inputs consting ~500 gas for the EIP-7883 review.π Related Issues
β Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.