Skip to content

feat(tests): EIP-7825: Transaction Gas Limit Cap #1711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 9, 2025
Merged

feat(tests): EIP-7825: Transaction Gas Limit Cap #1711

merged 5 commits into from
Jun 9, 2025

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Jun 3, 2025 •
edited by spencer-tb
Loading

🗒️ Description

Tests for EIP-7825, imposing a 30 million gas limit to every transaction type.

🔗 Related Issues

N/A

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.

@marioevz
Copy link
Member Author

marioevz commented Jun 4, 2025

Evmone coverage is complaining that tests/osaka/eip7825_transaction_gas_limit_cap/test_transaction_gas_limit_cap.py contains no ported tests.

@spencer-tb
Copy link
Contributor

Evmone coverage is complaining that tests/osaka/eip7825_transaction_gas_limit_cap/test_transaction_gas_limit_cap.py contains no ported tests.

Fixed!!

@spencer-tb spencer-tb added type:feat type: Feature fork:osaka Osaka hardfork scope:tests Scope: Changes EL client test cases in `./tests` labels Jun 9, 2025
spencer-tb
spencer-tb approved these changes Jun 9, 2025
View reviewed changes
Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

Merging for now. We can come back to this EIP pre-testnet, and go over the checklist.

@spencer-tb spencer-tb merged commit 46d4490 into main Jun 9, 2025
25 checks passed
@spencer-tb spencer-tb deleted the eip-7825 branch June 9, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencer-tb spencer-tb spencer-tb approved these changes

Assignees
No one assigned
Labels
fork:osaka Osaka hardfork scope:tests Scope: Changes EL client test cases in `./tests` type:feat type: Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marioevz @spencer-tb