1176 - Initial python/pypy 3.11 refactors #1179
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carsons-Eels
changed the title
Carsons-Eels
force-pushed
the
1176_inital_311_refactors
branch
4 times, most recently
from
18059e7 to
3778acd
Compare
Carsons-Eels
changed the title
|
I included the commit from PR #1177 because otherwise you can't test it locally as it requires the upgrade to py/py 3.11 to function correctly. That commit can either be dropped pre-approval, or this commit can just be merged immediately after 1177. |
Carsons-Eels
force-pushed
the
1176_inital_311_refactors
branch
from
3778acd to
bf3789c
Compare
Carsons-Eels
force-pushed
the
1176_inital_311_refactors
branch
from
bf3789c to
0bb658f
Compare
SamWilsn
reviewed
Jun 17, 2025
src/ethereum/crypto/finite_field.py
Outdated
There was a problem hiding this comment.
Where is this coming from?
Carsons-Eels
force-pushed
the
1176_inital_311_refactors
branch
from
0bb658f to
8799f7a
Compare
SamWilsn
approved these changes
Jun 17, 2025
Carsons-Eels
force-pushed
the
1176_inital_311_refactors
branch
from
8799f7a to
fa144d4
Compare
- refactored assert_type import from typing_extensions to typing - refactored Union to use primitive type offered by 3.10
Carsons-Eels
force-pushed
the
1176_inital_311_refactors
branch
from
fa144d4 to
9139169
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
New pypy version was released supporting python 3.11. Basic upgrades to code were needed.
Closes #1176
Related to Issue #1144
How was it fixed?
Refactored
Uniontype introduced by python3.10rather thantyping.Unionassert_typefrom typing rather thantyping_extensionsWord of Caution⚠️
This should be merged AFTER PR #1177✔️Cute Animal Picture