Skip to content

Refactor transaction validation to use MAX_INIT_CODE_SIZE instead of MAX_CODE_SIZE across multiple modules #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor transaction validation to use MAX_INIT_CODE_SIZE instead of MAX_CODE_SIZE across multiple modules #1243

wants to merge 1 commit into from
+15 −12

Conversation

timsburk
Copy link

@timsburk timsburk commented May 22, 2025 •
edited
Loading

What was wrong?

How was it fixed?

  1. Explicitly defined MAX_INIT_CODE_SIZE = 2 * MAX_CODE_SIZE as a new constant in the vm/interpreter.py files for the Shanghai, Cancun, and Prague forks.
  2. Updated relevant code in transactions.py and vm/instructions/system.py for these forks to use the new MAX_INIT_CODE_SIZE constant when validating initcode sizes, replacing direct usage of 2 * MAX_CODE_SIZE.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@timsburk timsburk mentioned this pull request May 23, 2025
Open
@timsburk
Copy link
Author

@gurukamath hey, what do I need to do to pass the checks ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gurukamath gurukamath gurukamath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explicitly define MAX_INIT_CODE_SIZE as a constant
2 participants
@timsburk @gurukamath