Implement EIP-7002 #950
Merged
Implement EIP-7002 #950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurukamath
requested review from
SamWilsn and
petertdavies
and removed request for
SamWilsn
petertdavies
previously requested changes
May 17, 2024
|
@petertdavies Have made the requested changes and additionally, removed the |
gurukamath
force-pushed
the
eips/prague/eip-7002
branch
from
9a95abc to
886ec59
Compare
SamWilsn
reviewed
Jun 18, 2024
src/ethereum/prague/blocks.py
Outdated
| """ | ||
| Parses Withdrawal Request from the data. | ||
| """ | ||
| assert len(data) == 76 |
There was a problem hiding this comment.
76 is repeated a lot. Can we make a constant for it?
SamWilsn
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
EIP-7002 is not implemented in the specs
Related to Issue #939
How was it fixed?
Implement EIP-7002