Skip to content

Make vertx request header case insensitive #6924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2025
Merged

Conversation

Malandril
Copy link
Contributor

Description

Make vertx http request's header case insensitive to fix case related issues.

Fixes #6917

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@shawkins
Copy link
Contributor

shawkins commented Mar 3, 2025

@manusa do you also want to make the standard impl case-insensitive?

@manusa
Copy link
Member

manusa commented Mar 3, 2025

@manusa do you also want to make the standard impl case-insensitive?

Headers should be case-insensitive. Also, HTTP >1 keys should usually be lower-cased AFAIR.

I remember dealing with this in the past (probably when implementing the StandardHttpClient or the TestHttpClient).
Haven't dug into the current issue yet, I'm not sure what might have caused it.

@manusa manusa self-assigned this Mar 10, 2025
@manusa manusa moved this to In Progress in Eclipse JKube Mar 10, 2025
@manusa manusa moved this from In Progress to Review in Eclipse JKube Mar 10, 2025
Copy link

@manusa manusa added this to the 7.2.0 milestone Mar 10, 2025 — with automated-tasks
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit 2675998 into fabric8io:main Mar 10, 2025
20 checks passed
@github-project-automation github-project-automation bot moved this from Review to Done in Eclipse JKube Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fabric 8 client does not authenticate correctly on openshift if the returned Location header is lower case
3 participants