fix: override only existing searchParams #1509
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #1480
When implementing Module Federation for Metro, we're reusing existing lazy bundling for production bundles, and we wanted to clean up the bundlePaths for the production bundles by not adding any query params to it. Since the
searchParams
are entirely based onsourceUrl
, we can avoid addingsearchParams
by having a cleansourceUrl
.This PR does two things:
runModule
&modulesOnly
params happen only when those params are present?
to the URL when there are nosearchParams
Changelog: [Fix] Only override existing runModule & modulesOnly search params when processing bundle async paths
Note
Marking this as
fix
since the spec mentionsoverriding
params and notsetting
themTest plan