Skip to content

Fix compilation error in optional.h when trying to compile watchman. #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matts1
Copy link

@matts1 matts1 commented May 14, 2025

FAILED: quic/dsr/CMakeFiles/mvfst_dsr_frontend.dir/frontend/Scheduler.cpp.o 
/usr/bin/c++ -DBOOST_ATOMIC_NO_LIB -DBOOST_CONTEXT_NO_LIB -DBOOST_FILESYSTEM_NO_LIB -DBOOST_PROGRAM_OPTIONS_NO_LIB -DBOOST_REGEX_NO_LIB -DBOOST_SYSTEM_NO_LIB -DBOOST_THREAD_NO_LIB -DGFLAGS_IS_A_DLL=0 -I/tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/repos/proxy-git.cwkhome.fun-facebook-mvfst.git -isystem /tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/installed/boost-WWAdUuDHG4SZiSWNWLTtXVV60aeQCkRT_TY1CGrKCz0/include -isystem /usr/include/libdwarf -isystem /tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/installed/folly/include -isystem /tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/installed/fmt-sUAsk0jwHE0LTHTgdPkn_3B2kUYhIToULRKySRDSjoI/include -isystem /tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/installed/fizz/include -O2 -g -DNDEBUG -std=c++17 -Wall -Wextra -Woverloaded-virtual -Wnon-virtual-dtor -Wtype-limits -Wunused-value -MD -MT quic/dsr/CMakeFiles/mvfst_dsr_frontend.dir/frontend/Scheduler.cpp.o -MF quic/dsr/CMakeFiles/mvfst_dsr_frontend.dir/frontend/Scheduler.cpp.o.d -o quic/dsr/CMakeFiles/mvfst_dsr_frontend.dir/frontend/Scheduler.cpp.o -c /tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/repos/proxy-git.cwkhome.fun-facebook-mvfst.git/quic/dsr/frontend/Scheduler.cpp
In file included from /tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/repos/proxy-git.cwkhome.fun-facebook-mvfst.git/quic/common/Optional.h:12,
                 from /tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/repos/proxy-git.cwkhome.fun-facebook-mvfst.git/quic/codec/QuicConnectionId.h:10,
                 from /tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/repos/proxy-git.cwkhome.fun-facebook-mvfst.git/quic/dsr/frontend/PacketBuilder.h:11,
                 from /tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/repos/proxy-git.cwkhome.fun-facebook-mvfst.git/quic/dsr/frontend/Scheduler.h:10,
                 from /tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/repos/proxy-git.cwkhome.fun-facebook-mvfst.git/quic/dsr/frontend/Scheduler.cpp:8:
/tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/repos/proxy-git.cwkhome.fun-facebook-mvfst.git/quic/common/third-party/optional.h: In member function ‘quic::detail::tiny::quic_tiny_opt_100300_noBit_noMem::impl::TinyOptionalImpl<StoredTypeDecomposition, FlagManipulator>::PayloadType& quic::detail::tiny::quic_tiny_opt_100300_noBit_noMem::impl::TinyOptionalImpl<StoredTypeDecomposition, FlagManipulator>::value() &’:
/tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/repos/proxy-git.cwkhome.fun-facebook-mvfst.git/quic/common/third-party/optional.h:1591:14: error: ‘abort’ is not a member of ‘std’
 1591 |         std::abort();
      |              ^~~~~
/tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/repos/proxy-git.cwkhome.fun-facebook-mvfst.git/quic/common/third-party/optional.h: In member function ‘const quic::detail::tiny::quic_tiny_opt_100300_noBit_noMem::impl::TinyOptionalImpl<StoredTypeDecomposition, FlagManipulator>::PayloadType& quic::detail::tiny::quic_tiny_opt_100300_noBit_noMem::impl::TinyOptionalImpl<StoredTypeDecomposition, FlagManipulator>::value() const &’:
/tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/repos/proxy-git.cwkhome.fun-facebook-mvfst.git/quic/common/third-party/optional.h:1600:14: error: ‘abort’ is not a member of ‘std’
 1600 |         std::abort();
      |              ^~~~~
/tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/repos/proxy-git.cwkhome.fun-facebook-mvfst.git/quic/common/third-party/optional.h: In member function ‘quic::detail::tiny::quic_tiny_opt_100300_noBit_noMem::impl::TinyOptionalImpl<StoredTypeDecomposition, FlagManipulator>::PayloadType&& quic::detail::tiny::quic_tiny_opt_100300_noBit_noMem::impl::TinyOptionalImpl<StoredTypeDecomposition, FlagManipulator>::value() &&’:
/tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/repos/proxy-git.cwkhome.fun-facebook-mvfst.git/quic/common/third-party/optional.h:1609:14: error: ‘abort’ is not a member of ‘std’
 1609 |         std::abort();
      |              ^~~~~
/tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/repos/proxy-git.cwkhome.fun-facebook-mvfst.git/quic/common/third-party/optional.h: In member function ‘const quic::detail::tiny::quic_tiny_opt_100300_noBit_noMem::impl::TinyOptionalImpl<StoredTypeDecomposition, FlagManipulator>::PayloadType&& quic::detail::tiny::quic_tiny_opt_100300_noBit_noMem::impl::TinyOptionalImpl<StoredTypeDecomposition, FlagManipulator>::value() const &&’:
/tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/repos/proxy-git.cwkhome.fun-facebook-mvfst.git/quic/common/third-party/optional.h:1618:14: error: ‘abort’ is not a member of ‘std’
 1618 |         std::abort();
      |              ^~~~~
ninja: build stopped: subcommand failed.
Command '['/usr/bin/cmake', '--build', '/tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/build/mvfst', '--target', 'install', '--config', 'RelWithDebInfo', '-j', '111']' returned non-zero exit status 1.
!! Failed

```
FAILED: quic/dsr/CMakeFiles/mvfst_dsr_frontend.dir/frontend/Scheduler.cpp.o 
/usr/bin/c++ -DBOOST_ATOMIC_NO_LIB -DBOOST_CONTEXT_NO_LIB -DBOOST_FILESYSTEM_NO_LIB -DBOOST_PROGRAM_OPTIONS_NO_LIB -DBOOST_REGEX_NO_LIB -DBOOST_SYSTEM_NO_LIB -DBOOST_THREAD_NO_LIB -DGFLAGS_IS_A_DLL=0 -I/tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/repos/proxy-git.cwkhome.fun-facebook-mvfst.git -isystem /tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/installed/boost-WWAdUuDHG4SZiSWNWLTtXVV60aeQCkRT_TY1CGrKCz0/include -isystem /usr/include/libdwarf -isystem /tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/installed/folly/include -isystem /tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/installed/fmt-sUAsk0jwHE0LTHTgdPkn_3B2kUYhIToULRKySRDSjoI/include -isystem /tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/installed/fizz/include -O2 -g -DNDEBUG -std=c++17 -Wall -Wextra -Woverloaded-virtual -Wnon-virtual-dtor -Wtype-limits -Wunused-value -MD -MT quic/dsr/CMakeFiles/mvfst_dsr_frontend.dir/frontend/Scheduler.cpp.o -MF quic/dsr/CMakeFiles/mvfst_dsr_frontend.dir/frontend/Scheduler.cpp.o.d -o quic/dsr/CMakeFiles/mvfst_dsr_frontend.dir/frontend/Scheduler.cpp.o -c /tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/repos/proxy-git.cwkhome.fun-facebook-mvfst.git/quic/dsr/frontend/Scheduler.cpp
In file included from /tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/repos/proxy-git.cwkhome.fun-facebook-mvfst.git/quic/common/Optional.h:12,
                 from /tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/repos/proxy-git.cwkhome.fun-facebook-mvfst.git/quic/codec/QuicConnectionId.h:10,
                 from /tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/repos/proxy-git.cwkhome.fun-facebook-mvfst.git/quic/dsr/frontend/PacketBuilder.h:11,
                 from /tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/repos/proxy-git.cwkhome.fun-facebook-mvfst.git/quic/dsr/frontend/Scheduler.h:10,
                 from /tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/repos/proxy-git.cwkhome.fun-facebook-mvfst.git/quic/dsr/frontend/Scheduler.cpp:8:
/tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/repos/proxy-git.cwkhome.fun-facebook-mvfst.git/quic/common/third-party/optional.h: In member function ‘quic::detail::tiny::quic_tiny_opt_100300_noBit_noMem::impl::TinyOptionalImpl<StoredTypeDecomposition, FlagManipulator>::PayloadType& quic::detail::tiny::quic_tiny_opt_100300_noBit_noMem::impl::TinyOptionalImpl<StoredTypeDecomposition, FlagManipulator>::value() &’:
/tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/repos/proxy-git.cwkhome.fun-facebook-mvfst.git/quic/common/third-party/optional.h:1591:14: error: ‘abort’ is not a member of ‘std’
 1591 |         std::abort();
      |              ^~~~~
/tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/repos/proxy-git.cwkhome.fun-facebook-mvfst.git/quic/common/third-party/optional.h: In member function ‘const quic::detail::tiny::quic_tiny_opt_100300_noBit_noMem::impl::TinyOptionalImpl<StoredTypeDecomposition, FlagManipulator>::PayloadType& quic::detail::tiny::quic_tiny_opt_100300_noBit_noMem::impl::TinyOptionalImpl<StoredTypeDecomposition, FlagManipulator>::value() const &’:
/tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/repos/proxy-git.cwkhome.fun-facebook-mvfst.git/quic/common/third-party/optional.h:1600:14: error: ‘abort’ is not a member of ‘std’
 1600 |         std::abort();
      |              ^~~~~
/tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/repos/proxy-git.cwkhome.fun-facebook-mvfst.git/quic/common/third-party/optional.h: In member function ‘quic::detail::tiny::quic_tiny_opt_100300_noBit_noMem::impl::TinyOptionalImpl<StoredTypeDecomposition, FlagManipulator>::PayloadType&& quic::detail::tiny::quic_tiny_opt_100300_noBit_noMem::impl::TinyOptionalImpl<StoredTypeDecomposition, FlagManipulator>::value() &&’:
/tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/repos/proxy-git.cwkhome.fun-facebook-mvfst.git/quic/common/third-party/optional.h:1609:14: error: ‘abort’ is not a member of ‘std’
 1609 |         std::abort();
      |              ^~~~~
/tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/repos/proxy-git.cwkhome.fun-facebook-mvfst.git/quic/common/third-party/optional.h: In member function ‘const quic::detail::tiny::quic_tiny_opt_100300_noBit_noMem::impl::TinyOptionalImpl<StoredTypeDecomposition, FlagManipulator>::PayloadType&& quic::detail::tiny::quic_tiny_opt_100300_noBit_noMem::impl::TinyOptionalImpl<StoredTypeDecomposition, FlagManipulator>::value() const &&’:
/tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/repos/proxy-git.cwkhome.fun-facebook-mvfst.git/quic/common/third-party/optional.h:1618:14: error: ‘abort’ is not a member of ‘std’
 1618 |         std::abort();
      |              ^~~~~
ninja: build stopped: subcommand failed.
Command '['/usr/bin/cmake', '--build', '/tmp/fbcode_builder_getdeps-ZusrZlocalZgoogleZhomeZmstaZwatchmanZbuildZfbcode_builder/build/mvfst', '--target', 'install', '--config', 'RelWithDebInfo', '-j', '111']' returned non-zero exit status 1.
!! Failed
```
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants