add asdf-vm support in react-native-xcode.sh

[pastleo]

About asdf-vm: https://asdf-vm.com/

Summary

This PR add asdf-vm support to find-node.sh for scripts/react-native-xcode.sh in Bundle React Native code and images build phrase and potentially other scripts using find-node.sh to get executable nodejs

Changelog

[iOS] [Added] - add asdf-vm support in find-node.sh

Test Plan

Xcode is able to complete Bundle React Native code and images build phrase without errors when node is installed by asdf-vm

[facebook-github-bot]

Hi @pastleo!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[pvinis]

I guess this and #31317 can go together. I see some tiny differences, -x, -s, -f not used the same way.

[pvinis]

also, why is this script for xcode not using the find-node script??! The change there should be enough for all the things within RN to find the right node without duplicating code.

[facebook-github-bot]

@charlesbdudley has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[charlesbdudley]

HI @pastleo, can we move this change to find-node.sh alongside the other environment manager code?

[pastleo]

also, why is this script for xcode not using the find-node script??! The change there should be enough for all the things within RN to find the right node without duplicating code.

because this PR was created (2020/10) before scripts/find-node.sh (2021/1, if the commit history is correct)

HI @pastleo, can we move this change to find-node.sh alongside the other environment manager code?

sure, please do, and maybe I should close this PR?

[charlesbdudley]

@pastleo, sorry, I meant do you mind making the change? :)

[pastleo]

@pastleo, sorry, I meant do you mind making the change? :)

OK, but I wasn't developing RN for quite a while now, I will make the change when I have time (and setup a project to test as well)
Should I open new PR? or just modify this one?

[pastleo]

@charlesbdudley I just moved the change to find-node.sh, also created a new RN project to test and it is working

[facebook-github-bot]

@charlesbdudley has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was successfully merged by @pastleo in 3e7c310.

^{When will my fix make it into a release? | Upcoming Releases}

[react-native-bot]

This pull request was successfully merged by @pastleo in 3e7c310.

^{When will my fix make it into a release? | Upcoming Releases}

[react-native-bot]

This pull request was successfully merged by @pastleo in 3e7c310.

^{When will my fix make it into a release? | Upcoming Releases}