Merge and align global.d.ts and globals.d.ts files #49516
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69772463 |
|
This pull request was exported from Phabricator. Differential Revision: D69772463 |
coado
added a commit
to coado/react-native
that referenced
this pull request
Feb 21, 2025
Summary: Pull Request resolved: facebook#49516 Merge global.d.ts and globals.d.ts into one file and align some definitions with implementations. Changelog: [General][Changed] - Improve TypeScript types for `global` objects Reviewed By: huntie Differential Revision: D69772463
coado
force-pushed
the
export-D69772463
branch
from
b0f1102 to
43b4045
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69772463 |
coado
added a commit
to coado/react-native
that referenced
this pull request
Feb 21, 2025
Summary: Pull Request resolved: facebook#49516 Merge global.d.ts and globals.d.ts into one file and align some definitions with implementations. Changelog: [General][Changed] - Improve TypeScript types for `global` objects Reviewed By: huntie Differential Revision: D69772463
coado
force-pushed
the
export-D69772463
branch
from
43b4045 to
63f16f4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69772463 |
coado
added a commit
to coado/react-native
that referenced
this pull request
Feb 21, 2025
Summary: Pull Request resolved: facebook#49516 Merge global.d.ts and globals.d.ts into one file and align some definitions with implementations. Changelog: [General][Changed] - Improve TypeScript types for `global` objects Reviewed By: huntie Differential Revision: D69772463
coado
force-pushed
the
export-D69772463
branch
from
63f16f4 to
2306fa8
Compare
Summary: dtslint throws an error when <reference path> is used to reference another package. The suggested approach is to use <reference types> instead. It requires that the [email protected] is used. Differential Revision: D69749044
|
This pull request was exported from Phabricator. Differential Revision: D69772463 |
coado
force-pushed
the
export-D69772463
branch
from
2306fa8 to
14dcbd9
Compare
coado
added a commit
to coado/react-native
that referenced
this pull request
Feb 24, 2025
Summary: Pull Request resolved: facebook#49516 Merge global.d.ts and globals.d.ts into one file and align some definitions with implementations. Changelog: [General][Changed] - Improve TypeScript types for `global` objects Reviewed By: huntie Differential Revision: D69772463
|
This pull request was exported from Phabricator. Differential Revision: D69772463 |
coado
added a commit
to coado/react-native
that referenced
this pull request
Feb 24, 2025
Summary: Pull Request resolved: facebook#49516 Merge global.d.ts and globals.d.ts into one file and align some definitions with implementations. Changelog: [General][Changed] - Improve TypeScript types for `global` objects Reviewed By: huntie Differential Revision: D69772463
coado
force-pushed
the
export-D69772463
branch
from
14dcbd9 to
4d2c867
Compare
Summary: Pull Request resolved: facebook#49516 Merge global.d.ts and globals.d.ts into one file and align some definitions with implementations. Changelog: [General][Changed] - Improve TypeScript types for `global` objects Reviewed By: huntie Differential Revision: D69772463
|
This pull request was exported from Phabricator. Differential Revision: D69772463 |
coado
force-pushed
the
export-D69772463
branch
from
4d2c867 to
45207bd
Compare
|
This pull request has been merged in 094c5be. |
facebook-github-bot
pushed a commit
that referenced
this pull request
May 20, 2025
Summary: After #49516 TSC would not find the global types. Types reference expect a package name but was given a path to a declaration. TS doc: https://www.typescriptlang.org/docs/handbook/triple-slash-directives.html#-reference-path- This PR changes `types` to `path` to fix the issue. `dtslint` fails with `no-bad-reference` rule, but the `../src` lives in the same package in `react-native` package. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [GENERAL] [FIXED] - Reference `global.d.ts` using `path` so they can be resolved by TSC Pull Request resolved: #51104 Test Plan: Before the change with current RN 0.79.2 TSC would fail on resolving the global types (example from [Sentry RN SDK build](getsentry/sentry-react-native@134d810)):  After the change to path TSC finds the global types. Using TSC Version 4.9.5 Reviewed By: huntie Differential Revision: D74208815 Pulled By: coado fbshipit-source-id: 2fd51d79061ffb356c047604213cff7a425f167e
react-native-bot
pushed a commit
that referenced
this pull request
May 23, 2025
Summary: After #49516 TSC would not find the global types. Types reference expect a package name but was given a path to a declaration. TS doc: https://www.typescriptlang.org/docs/handbook/triple-slash-directives.html#-reference-path- This PR changes `types` to `path` to fix the issue. `dtslint` fails with `no-bad-reference` rule, but the `../src` lives in the same package in `react-native` package. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [GENERAL] [FIXED] - Reference `global.d.ts` using `path` so they can be resolved by TSC Pull Request resolved: #51104 Test Plan: Before the change with current RN 0.79.2 TSC would fail on resolving the global types (example from [Sentry RN SDK build](getsentry/sentry-react-native@134d810)):  After the change to path TSC finds the global types. Using TSC Version 4.9.5 Reviewed By: huntie Differential Revision: D74208815 Pulled By: coado fbshipit-source-id: 2fd51d79061ffb356c047604213cff7a425f167e
cipolleschi
pushed a commit
that referenced
this pull request
Jun 4, 2025
Summary: After #49516 TSC would not find the global types. Types reference expect a package name but was given a path to a declaration. TS doc: https://www.typescriptlang.org/docs/handbook/triple-slash-directives.html#-reference-path- This PR changes `types` to `path` to fix the issue. `dtslint` fails with `no-bad-reference` rule, but the `../src` lives in the same package in `react-native` package. <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [GENERAL] [FIXED] - Reference `global.d.ts` using `path` so they can be resolved by TSC Pull Request resolved: #51104 Test Plan: Before the change with current RN 0.79.2 TSC would fail on resolving the global types (example from [Sentry RN SDK build](getsentry/sentry-react-native@134d810)):  After the change to path TSC finds the global types. Using TSC Version 4.9.5 Reviewed By: huntie Differential Revision: D74208815 Pulled By: coado fbshipit-source-id: 2fd51d79061ffb356c047604213cff7a425f167e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Merge global.d.ts and globals.d.ts into one file and align some definitions with implementations.
Changelog:
[General][Changed] - Improve TypeScript types for
globalobjectsReviewed By: huntie
Differential Revision: D69772463