[ios][prebuild] build xcframeworks from prebuild script #51596
Conversation
This commit adds building the swift package from the prebuild script: - Added swiftpackage.js for building the swift package - Added calling building from the main script - Added configurable build type from the main script. - Removed params in jsdoc from the link method
This commit adds support for building XCFrameworks from the prebuild-script - Added build script to help build xcframeworks - Added full header file structure - Added calling the build script from the main prebuild script TODO: We need to add resources / privacy bundles
facebook-github-bot
added
CLA Signed
| const fileName = path.basename(filePath, path.extname(filePath)); | ||
| const cppFilePath = path.join( | ||
| path.dirname(filePath), | ||
| fileName + (fileName.endsWith('mm') ? '.cpp' : '.mm'), |
There was a problem hiding this comment.
| fileName + (fileName.endsWith('mm') ? '.cpp' : '.mm'), | |
| fileName + (!fileName.endsWith('mm') ? '.cpp' : '.mm'), |
why are we adding the .cpp extension if the file ends with mm? 🤔
There was a problem hiding this comment.
In the framework, we also have some pure C++ headers, with no implementation code.
I think it is fine so far, as I don't think we have such things in Objc.. Maybe some protocol only files... 🤔
How are we handling that case?
There was a problem hiding this comment.
I'm not super happy with how the "automatic" detection of header files are done here, but maybe we can make a more static list when we move away from cocoapods. This implementation was the smallest denominator to get a demo project up and running. I expect us to have to refactor this when we find missing headers in f.ex. Expo.
There was a problem hiding this comment.
that makes sense. We can use this as a starting point!
chrfalch
changed the title
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary
This commit adds support for building XCFrameworks from the prebuild-script
TODO: We need to add resources / privacy bundles
Changelog:
[IOS] [ADDED] - Added building XCFframework from the prebuild script
Test Plan:
Run prebuild script and verify that XCFrameworks are successfully built.