Remove redundant work during mounting Indeterminate Component #13599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundled changes.Comparing: 7d1169b...607e68f schedule
Generated by 🚫 dangerJS |
yunchancho
changed the title
During mounting Indeterminate Component, it's redundant to check and call getDerivedStateFromProps method. Because getDerivedStateFromProps method will be called by mountClassInstance right after changing the fiber's tag to Class Component.
yunchancho
force-pushed
the
improvement/react-reconciler
branch
from
f0b9621 to
607e68f
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution. |
|
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During mounting Indeterminate Component, it's redundant to check and call
getDerivedStateFromPropsmethod.Because
getDerivedStateFromPropsmethod will be called bymountClassInstancefunction right after changing the fiber's tag to Class Component.So this PR remove code regarding this redundant work.