Skip to content

[Flight] Add filterStackFrame options to the RSC Server #30447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2024
Merged

[Flight] Add filterStackFrame options to the RSC Server #30447

merged 1 commit into from
Jul 25, 2024

Conversation

sebmarkbage
Copy link
Collaborator

@sebmarkbage sebmarkbage commented Jul 24, 2024 •
edited
Loading

This lets you customize the filter, for example allowing node_modules or filter out additional functions that you don't want to include when sending the stack to the client.

Notably this doesn't filter out Server Components out of the parent stack. Those are just like a view of the tree by name. Not virtual stack frames.

@sebmarkbage sebmarkbage requested a review from eps1lon July 24, 2024 20:02
@vercel Vercel
Copy link

vercel bot commented Jul 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 9:02pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 24, 2024
@sebmarkbage
Add filterStackFrame options to FlightServer
93d50a6 
This lets you customize the filter, for example allowing node_modules or
filter out additional functions that you don't want to include when sending
the stack to the client.
@sebmarkbage sebmarkbage force-pushed the configureignorelist branch from 6295899 to 93d50a6 Compare July 24, 2024 20:57
@react-sizebot
Copy link

Comparing: a6b7e43...2fa24ce

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 501.44 kB 501.44 kB = 89.98 kB 89.98 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 506.26 kB 506.26 kB = 90.68 kB 90.68 kB
facebook-www/ReactDOM-prod.classic.js = 599.78 kB 599.78 kB = 105.88 kB 105.88 kB
facebook-www/ReactDOM-prod.modern.js = 575.83 kB 575.83 kB = 102.15 kB 102.15 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js +2.89% 2.38 kB 2.45 kB +1.66% 0.78 kB 0.80 kB
oss-stable-rc/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js +2.89% 2.38 kB 2.45 kB +1.66% 0.78 kB 0.80 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js +2.89% 2.38 kB 2.45 kB +1.66% 0.78 kB 0.80 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js +2.89% 2.38 kB 2.45 kB +1.66% 0.78 kB 0.80 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js +2.89% 2.38 kB 2.45 kB +1.66% 0.78 kB 0.80 kB
oss-stable-rc/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js +2.89% 2.38 kB 2.45 kB +1.66% 0.78 kB 0.80 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js +2.89% 2.38 kB 2.45 kB +1.66% 0.78 kB 0.80 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.development.js +2.89% 2.38 kB 2.45 kB +1.66% 0.78 kB 0.80 kB
oss-experimental/react-server/cjs/react-server-flight.development.js +0.64% 98.46 kB 99.09 kB +0.28% 18.17 kB 18.22 kB
oss-stable-rc/react-server/cjs/react-server-flight.development.js +0.62% 84.65 kB 85.18 kB +0.51% 15.75 kB 15.83 kB
oss-stable-semver/react-server/cjs/react-server-flight.development.js +0.62% 84.65 kB 85.18 kB +0.51% 15.75 kB 15.83 kB
oss-stable/react-server/cjs/react-server-flight.development.js +0.62% 84.65 kB 85.18 kB +0.51% 15.75 kB 15.83 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +0.48% 139.17 kB 139.84 kB +0.30% 25.79 kB 25.87 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +0.48% 144.92 kB 145.61 kB +0.27% 26.72 kB 26.79 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +0.48% 145.07 kB 145.76 kB +0.26% 26.79 kB 26.86 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js +0.46% 145.54 kB 146.21 kB +0.31% 26.76 kB 26.84 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js +0.46% 145.70 kB 146.37 kB +0.31% 26.82 kB 26.90 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js +0.46% 146.65 kB 147.32 kB +0.32% 27.02 kB 27.11 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +0.46% 146.80 kB 147.47 kB +0.32% 27.08 kB 27.17 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js +0.45% 142.18 kB 142.81 kB +0.25% 26.32 kB 26.38 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +0.45% 142.80 kB 143.44 kB +0.26% 26.49 kB 26.56 kB
oss-stable-rc/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +0.44% 124.64 kB 125.19 kB +0.35% 23.29 kB 23.37 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +0.44% 124.64 kB 125.19 kB +0.35% 23.29 kB 23.37 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js +0.44% 124.64 kB 125.19 kB +0.35% 23.29 kB 23.37 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +0.43% 129.59 kB 130.15 kB +0.33% 24.09 kB 24.17 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +0.43% 129.59 kB 130.15 kB +0.33% 24.09 kB 24.17 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js +0.43% 129.59 kB 130.15 kB +0.33% 24.09 kB 24.17 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +0.43% 129.74 kB 130.30 kB +0.33% 24.16 kB 24.24 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +0.43% 129.74 kB 130.30 kB +0.33% 24.16 kB 24.24 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js +0.43% 129.74 kB 130.30 kB +0.33% 24.16 kB 24.24 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js +0.42% 131.01 kB 131.56 kB +0.34% 24.25 kB 24.33 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js +0.42% 131.01 kB 131.56 kB +0.34% 24.25 kB 24.33 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.unbundled.development.js +0.42% 131.01 kB 131.56 kB +0.34% 24.25 kB 24.33 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js +0.42% 131.17 kB 131.72 kB +0.33% 24.31 kB 24.39 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js +0.42% 131.17 kB 131.72 kB +0.33% 24.31 kB 24.39 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js +0.42% 131.17 kB 131.72 kB +0.33% 24.31 kB 24.39 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js +0.41% 132.13 kB 132.67 kB +0.31% 24.52 kB 24.59 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js +0.41% 132.13 kB 132.67 kB +0.31% 24.52 kB 24.59 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js +0.41% 132.13 kB 132.67 kB +0.31% 24.52 kB 24.59 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +0.41% 132.27 kB 132.82 kB +0.31% 24.58 kB 24.66 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +0.41% 132.27 kB 132.82 kB +0.31% 24.58 kB 24.66 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js +0.41% 132.27 kB 132.82 kB +0.31% 24.58 kB 24.66 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js +0.41% 128.42 kB 128.94 kB +0.30% 23.89 kB 23.96 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js +0.41% 128.42 kB 128.94 kB +0.30% 23.89 kB 23.96 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js +0.41% 128.42 kB 128.94 kB +0.30% 23.89 kB 23.96 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +0.41% 129.04 kB 129.57 kB +0.29% 24.07 kB 24.14 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +0.41% 129.04 kB 129.57 kB +0.29% 24.07 kB 24.14 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js +0.41% 129.04 kB 129.57 kB +0.29% 24.07 kB 24.14 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js = 2.10 kB 2.09 kB = 0.73 kB 0.72 kB
oss-stable-rc/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js = 2.10 kB 2.09 kB = 0.73 kB 0.72 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js = 2.10 kB 2.09 kB = 0.73 kB 0.72 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-flight-server.production.js = 2.10 kB 2.09 kB = 0.73 kB 0.72 kB

Generated by 🚫 dangerJS against 93d50a6

@sebmarkbage sebmarkbage merged commit 4b62400 into facebook:main Jul 25, 2024
187 checks passed
@eps1lon eps1lon mentioned this pull request Jul 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebmarkbage @react-sizebot @eps1lon @facebook-github-bot