Skip to content

perf: do not mutate req.raw #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2023
Merged

perf: do not mutate req.raw #488

merged 1 commit into from
Oct 8, 2023

Conversation

gurgunday
Copy link
Member

@gurgunday gurgunday commented Oct 8, 2023

Since we are using a Symbol to mark the request as multipart, I can't see a reason not to do this under fastify.req where we can decorate the object in advance and potentially get a performance improvement

Checklist

@gurgunday gurgunday requested a review from climba03003 October 8, 2023 10:29
Copy link
Member

@Eomm Eomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants