Merge next into master
#533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix error in processing file * fix error in processing file * add test * fix close * fix test * lint * revert change * Revert "revert change" This reverts commit 17ec56c. * node 14 :( * node 14 :( * add file * use filePath * delete foo * revert change * remove console.log * add test number * increase timeout * try fixing the error * try fixing the error * try reverting? * Revert "try reverting?" This reverts commit 35aca1e. * 90 * fix error * fix error * let request aborted destroy the file * simplify * simplify * ci
* fix error in processing file * fix error in processing file * add test * fix close * fix test * lint * revert change * Revert "revert change" This reverts commit 17ec56c. * node 14 :( * node 14 :( * add file * use filePath * delete foo * revert change * remove console.log * add test number * increase timeout * try fixing the error * try fixing the error * try reverting? * Revert "try reverting?" This reverts commit 35aca1e. * 90 * fix error * fix error * let request aborted destroy the file * simplify * simplify * ci
* fix error in processing file * fix error in processing file * add test * fix close * fix test * lint * revert change * Revert "revert change" This reverts commit 17ec56c. * node 14 :( * node 14 :( * add file * use filePath * delete foo * revert change * remove console.log * add test number * increase timeout * try fixing the error * try fixing the error * try reverting? * Revert "try reverting?" This reverts commit 35aca1e. * 90 * fix error * fix error * let request aborted destroy the file * simplify * simplify * ci
jsumners
commented
Jul 16, 2024
Comment on lines
-12
to
+11
| const sendToWormhole = require('stream-wormhole') | ||
| const streamToNull = require('./lib/stream-consumer') |
There was a problem hiding this comment.
I had to rip out this dependency because it was hanging up the big.test.js test (I think it was never consuming the stream). When I got done fixing the coverage requirement to get npm test to return $? === 0, I thought I already had a commit with the replacement and did a git commit --amend -n and couldn't figure out how to quit Vim without the commit going through. So it got amended into the rebase commit 🤷♂️
gurgunday
reviewed
Jul 17, 2024
Co-authored-by: Gürgün Dayıoğlu <[email protected]> Signed-off-by: James Sumners <[email protected]>
gurgunday
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled.