Skip to content

remove test skip since problem fixed in qonnx #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

jmitrevs
Copy link
Contributor

Description

There currently is one test that is skipped because the qonnx channels-last conversion fails with it. Wit the current head of qonnx, this is no longer the case, so we no longer need to skip the test. However, we need to update our test environment first, so this is created as a draft at the moment

Type of change

[x] Other (Specify) Stop skipping a test

Tests

The pytests should all pass after we create a new testing container.

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@jmitrevs jmitrevs changed the title remove the skip since problem fixed in qonnx remove test skip since problem fixed in qonnx Dec 13, 2024
@jmitrevs jmitrevs added this to the v1.1.0 milestone Jan 10, 2025
Copy link
Contributor

@bo3z bo3z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, can we create a new Docker image and run the tests, so this can be merged?

@jmitrevs
Copy link
Contributor Author

jmitrevs commented Mar 3, 2025

This depends on #1200. After that goes in, this should be able to go in (though it should be confirmed).

@jmitrevs jmitrevs added the please test Trigger testing by creating local PR branch label Mar 5, 2025
@jmitrevs jmitrevs marked this pull request as ready for review March 5, 2025 16:48
@bo3z bo3z merged commit 0aa705b into fastmachinelearning:main Mar 7, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please test Trigger testing by creating local PR branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants