Fixes for quantised RNNs in data type inconsistencies #1171
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Tests
TODO: Add additional tests; so far it has only been confirmed that this fixes issue #1166. However, our current tests don't have different data-types between weights and recurrent weights
Checklist
pre-commit
on the files I edited or added.Description
data_T
orweight_T
), when in fact they should beaccum_T
. I traced all the activations and they should now match the variables that are being passed by them. However, this would be worth double checking by someone else.Additional TODOs: