Skip to content

Fix pytorch upsample parsing #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vloncar
Copy link
Contributor

@vloncar vloncar commented Feb 6, 2025

Description

The parser for PyTorch Upsampling layer ignores including the batch dimension in output shape, causing the failure of parsing subsequent layers. Fixes #1184.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Tests

Extended test_upsampling_pytorch.py to have a layer afterwards.

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@vloncar vloncar requested a review from JanFSchulte February 6, 2025 18:08
@vloncar vloncar added the please test Trigger testing by creating local PR branch label Feb 6, 2025
@JanFSchulte
Copy link
Contributor

Thanks Vladimir! Lets run the tests to completion and I'll merge afterwards.

@JanFSchulte JanFSchulte merged commit 6a05587 into fastmachinelearning:main Feb 7, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please test Trigger testing by creating local PR branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error on config_from_pytorch_model when using two conv2d after upsample
2 participants