Skip to content

Fix paths to weights in build_lib.sh for VivadoAccelator backend #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

JanFSchulte
Copy link
Contributor

Fixes crashes of part7a of the tutorial in v.1.0.0 reported in #1157.
These were found to be to a missing configuration of the path to the weight files in the VivadoAccelator background and thus a failure of the predict() function of the compiled model.

Fixed by explicitly setting the path in build_lib.sh in the VivadoAccelerator, copied from the same file in the Vivado backend.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Tests

With v1.0.0 and the main branch, part7a of the tutorial crashes on the line

y_hls = hls_model.predict(np.ascontiguousarray(X_test))

With this fix, it no longer crashes.

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@vloncar vloncar merged commit a7a3951 into fastmachinelearning:main Feb 17, 2025
8 of 10 checks passed
@nghielme nghielme mentioned this pull request Mar 3, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug please test Trigger testing by creating local PR branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants