Fix paths to weights in build_lib.sh for VivadoAccelator backend #1198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes crashes of part7a of the tutorial in v.1.0.0 reported in #1157.
These were found to be to a missing configuration of the path to the weight files in the
VivadoAccelator
background and thus a failure of thepredict()
function of the compiled model.Fixed by explicitly setting the path in
build_lib.sh
in theVivadoAccelerator
, copied from the same file in theVivado
backend.Type of change
Tests
With v1.0.0 and the main branch, part7a of the tutorial crashes on the line
y_hls = hls_model.predict(np.ascontiguousarray(X_test))
With this fix, it no longer crashes.
Checklist
pre-commit
on the files I edited or added.