Skip to content

remove old variables when moving of scales #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Conversation

jmitrevs
Copy link
Contributor

Description

When moving scales, some old attributes can cause problems and should not be copied. This PR tries to limit the attributes that are copied

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Tests

A brevitas example triggered this issue. I am not sure if we should add it to a pytest.

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

@JanFSchulte
Copy link
Contributor

Tested this locally with a brevitas -> QONNX -> hls4ml workflow that crashes without this PR. With these changes, it works fine.

@JanFSchulte JanFSchulte merged commit 18ccc61 into main Feb 24, 2025
7 of 8 checks passed
@JanFSchulte JanFSchulte deleted the fix_move_scales branch February 24, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants