Remove dependence of profiling tools on torch #1233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pre-commit.ci autofix |
vloncar
approved these changes
Mar 17, 2025
laurilaatu
pushed a commit
to laurilaatu/hls4ml
that referenced
this pull request
May 20, 2025
* move WeightsTorch class to utils to avoid dependence of profiling tools on torch * [pre-commit.ci] auto fixes from pre-commit hooks * add missing import --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
WeightsTorchclass introduced in #1156 to a new file underutilsto avoid a direct dependence of the profiling tools on torch. This avoids having to add torch to the optional dependencies for profiling.Type of change
Tests
In the current master branch, the line
from hls4ml.model.profiling import numericalin part 2 of the tutorial fails because we don't have torch in the tutorial environment. After this PR, the import no longer fails in the tutorial environment.Checklist
pre-commiton the files I edited or added.