Skip to content

feat: Allow to use env variable FEAST_FS_YAML_FILE_PATH and FEATURE_REPO_DIR #5420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2025
Merged

feat: Allow to use env variable FEAST_FS_YAML_FILE_PATH and FEATURE_REPO_DIR #5420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions sdk/python/feast/cli/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
from feast.cli.stream_feature_views import stream_feature_views_cmd
from feast.cli.ui import ui
from feast.cli.validation_references import validation_references_cmd
from feast.constants import FEAST_FS_YAML_FILE_PATH_ENV_NAME
from feast.errors import FeastProviderLoginError
from feast.repo_config import load_repo_config
from feast.repo_operations import (
Expand Down Expand Up @@ -81,7 +82,8 @@ def format_options(self, ctx: click.Context, formatter: click.HelpFormatter):
@click.option(
"--chdir",
"-c",
help="Switch to a different feature repository directory before executing the given subcommand.",
envvar="FEATURE_REPO_DIR_ENV_VAR",
help="Switch to a different feature repository directory before executing the given subcommand. Can also be set via the FEATURE_REPO_DIR_ENV_VAR environment variable.",
)
@click.option(
"--log-level",
Expand All @@ -91,7 +93,7 @@ def format_options(self, ctx: click.Context, formatter: click.HelpFormatter):
@click.option(
"--feature-store-yaml",
"-f",
help="Override the directory where the CLI should look for the feature_store.yaml file.",
help=f"Override the directory where the CLI should look for the feature_store.yaml file. Can also be set via the {FEAST_FS_YAML_FILE_PATH_ENV_NAME} environment variable.",
)
@click.pass_context
def cli(
Expand Down
5 changes: 4 additions & 1 deletion sdk/python/tests/unit/transformation/test_spark_transformation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,10 @@ def remove_extra_spaces_sql(df, column_name):
@pytest.fixture
def spark_fixture():
spark = SparkSession.builder.appName("Testing PySpark Example").getOrCreate()
yield spark
try:
yield spark
finally:
spark.stop()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This helps to cleanup spark orphan process



@patch("feast.infra.compute_engines.spark.utils.get_or_create_new_spark_session")
Expand Down
Loading