fix: prevent panic when *http.Response is nil
#156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Kopping <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
|
@fergusstrange would you mind reviewing this please? |
dannykopping
added a commit
to coder/coder
that referenced
this pull request
Jun 2, 2025
Addresses fergusstrange/embedded-postgres#156 while maintainer is unresponsive Signed-off-by: Danny Kopping <[email protected]>
dannykopping
added a commit
to coder/coder
that referenced
this pull request
Jun 2, 2025
Addresses fergusstrange/embedded-postgres#156 while maintainer is unresponsive Signed-off-by: Danny Kopping <[email protected]>
dannykopping
added a commit
to coder/coder
that referenced
this pull request
Jun 2, 2025
Addresses fergusstrange/embedded-postgres#156 while maintainer is unresponsive Signed-off-by: Danny Kopping <[email protected]>
|
Sorry @dannykopping for the delay. Merging now and creating release. |
|
No worries @fergusstrange, appreciate it! |
dannykopping
added a commit
to coder/coder
that referenced
this pull request
Jun 2, 2025
fergusstrange/embedded-postgres#156 was merged and [v1.31.0](https://github.com/fergusstrange/embedded-postgres/releases/tag/v1.31.0) was cut. Signed-off-by: Danny Kopping <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closeBodycan be called with a nil*http.Response, which will panic.We observed this occurring in our CI: https://github.com/coder/coder/actions/runs/15155935941/job/42610796260
I've also added explicit error handling for sha256 download failures. I'm not quite sure what caused the issue in our CI run above. Appears to be transient/flaky, so who knows.