Skip to content

Sd/ruby/add object codegen #7491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Sd/ruby/add object codegen #7491

wants to merge 6 commits into from

Conversation

sohdas
Copy link

@sohdas sohdas commented Jun 11, 2025

Description

Changes Made

Testing

  • Unit tests added/updated
  • Manual testing completed

sohdas
sohdas commented Jun 11, 2025
View reviewed changes
generators/ruby-v2/ast/src/ast/Field.ts Outdated
export class Field extends AstNode {
public readonly name: string;
public readonly type: Type;
public readonly optional: boolean;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Field ought to support an arbitrary number of KeywordParameters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsinghvi dsinghvi Awaiting requested review from dsinghvi dsinghvi will be requested when the pull request is marked ready for review dsinghvi is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sohdas