Skip to content

chore(core): return registration tx response #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 7, 2025

Conversation

jrriehl
Copy link
Contributor

@jrriehl jrriehl commented May 6, 2025

Proposed Changes

Return registration transaction status and log hash on error. Also exposes tirneout height and gas limit parameters.

Types of changes

What type of change does this pull request make (put an x in the boxes that apply)?

  • Bug fix (non-breaking change that fixes an issue).
  • New feature added (non-breaking change that adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to stop working as expected).
  • Documentation update.
  • Something else (e.g., tests, scripts, example, deployment, infrastructure).

Checklist

Put an x in the boxes that apply:

  • I have read the CONTRIBUTING guide
  • Checks and tests pass locally

@jrriehl jrriehl requested review from Archento, lrahmani and qati as code owners May 6, 2025 16:27
Copy link

github-actions bot commented May 6, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  python/src/uagents
  network.py
  registration.py
Project Total  

This report was generated by python-coverage-comment-action

lrahmani
lrahmani previously approved these changes May 6, 2025
Copy link
Contributor

@lrahmani lrahmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Archento Archento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea but we may be able to make better use of the new cosmpy feature 👍🏻

@jrriehl jrriehl enabled auto-merge (squash) May 7, 2025 10:32
@jrriehl jrriehl merged commit 4c91a8a into main May 7, 2025
10 checks passed
@jrriehl jrriehl deleted the chore/return-registration-tx-response branch May 7, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants