Code Quality: WCT Settings Control

[0x5bfa]

Feature: Settings Controls UI Refresh

Motivation & Context

• Improved performance
• Improved maintainability
• Improved UI (UI tweaks)

PR Checklist

• Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  Related Code Quality: Refactored the settings controls #12261
• Did you build the app and test your changes?
• Did you check for accessibility? You can use Accessibility Insights for this.
• Did you remove any strings from the en-us resource file?
  • Did you search the solution to see if the string is still being used?
• Did you implement any design changes to an existing feature?
  • Was this change approved?
• Are there any other steps that were used to validate these changes?

Screenshots

None

[yaira2]

Improved performance

Can you share some numbers 👀

[d2dyno1]

I know that CommunityToolkit Labs already has a control ready for that matter here

[0x5bfa]

This is experimental control and so I adopted. we can replace once that control become stable.

[yaira2]

Improved UI (UI tweaks)

Wasn't this supposed to be a code quality change? What types of UI changes are being introduced?

[0x5bfa]

Wasn't this supposed to be a code quality change? What types of UI changes are being introduced?

Like Windows 11 Settings controlls. full emphasizing the card's border on hovering.

[yaira2]

That's great, looking forward to reviewing this!

[yaira2]

Looking good, @0x5bfa can you remove the old control in this PR so that we don't have unnecessary duplication?

[Jay-o-Way]

@0x5bfa check the latest comment from Niels about the "experimental" status, or CommunityToolkit/Windows#116
(e.g. PowerToys has been using it for quite a while now)

[0x5bfa]

@yaira2 Ready for review

[0x5bfa]

@0x5bfa check the latest comment from Niels about the "experimental" status. (e.g. PowerToys has been using it for quite a while now)

PowerToys uses them because very he introduced them. besides, we dont wanna add extra packages and its still experimental, but once wct published 8.0 we can switch out and remove our own. the main point is not to add extra packages. not that we would not use beta or in dev controls (because i copied them😶).

[yaira2]

The specs for this change is to swap out the out control for the new one. I'm seeing a lot of unrelated changes here that are out of scope.

[0x5bfa]

Just converted those ViewModels into IoC. those few lines are unrelated? i will revert again then

[yaira2]

I'll have to take a closer look

[0x5bfa]

Ready for merging.

[yaira2]

It looks like the card heights in the properties window are different than what we have in main. I'll need some time to consider this change before deciding how to proceed.

[0x5bfa]

They should have consistency with other settings controls. But I can apply different design template.

[yaira2]

[yaira2]

It looks like toggle switches are wrapping onto the next line when they don't need to. Can you update the template to fix this issue?

[0x5bfa]

There's threshold to wrap action controls when window is small. Don't we need this?

[0x5bfa]

If you dont need this threshold I can set it 0.

[yaira2]

Is there a reason to keep the threshold?

[yaira2]

We can do the same for the "New tag" button.

[yaira2]

It appears that at a certain width, the text moves up a couple of pixels.

[0x5bfa]

It appears that at a certain width, the text moves up a couple of pixels.

Fixed.

[0x5bfa]

We dont need to add our own code because WCT just released 8.0 few days ago.
Once some UI bugs fixed, I will going to open PR to update to use those controls.