Skip to content

fix(firestore-send-email): SendGrid v3 issues #2020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 24, 2024
Merged

Conversation

jauntybrain
Copy link
Contributor

  • Use new SendGrid (v3) transport only when payload body contains sendGrid field
  • Fix an issue where text or html fields were null and not undefined which was resulting in an error.

Resolves #2004.

@cabljac cabljac force-pushed the @invertase/sendgrid-issues branch from bdfd292 to 3fe8e86 Compare March 27, 2024 10:18
@cabljac cabljac merged commit 6b6aae2 into next Apr 24, 2024
cabljac pushed a commit that referenced this pull request Apr 24, 2024
* fix(firestore-send-email): sendgrid v3 issues

* fix(firestore-send-email): remove sendgrid transporter test

* fix(firestore-send-email): handle sendgrid template edge cases

* chore: clean up comments & logs

---------

Co-authored-by: Pavel <k>
cabljac pushed a commit that referenced this pull request Apr 24, 2024
* fix(firestore-send-email): sendgrid v3 issues

* fix(firestore-send-email): remove sendgrid transporter test

* fix(firestore-send-email): handle sendgrid template edge cases

* chore: clean up comments & logs

---------

Co-authored-by: Pavel <k>
cabljac pushed a commit that referenced this pull request Apr 24, 2024
* fix(firestore-send-email): sendgrid v3 issues

* fix(firestore-send-email): remove sendgrid transporter test

* fix(firestore-send-email): handle sendgrid template edge cases

* chore: clean up comments & logs

---------
cabljac pushed a commit that referenced this pull request Apr 24, 2024
* fix(firestore-send-email): sendgrid v3 issues

* fix(firestore-send-email): remove sendgrid transporter test

* fix(firestore-send-email): handle sendgrid template edge cases

* chore: clean up comments & logs

---------
@pr-Mais pr-Mais deleted the @invertase/sendgrid-issues branch May 24, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [firestore-send-email] The delivery.info entry is missing after upgrading to 0.1.32.
3 participants