Skip to content

Fixing some integration test failures #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 16, 2019
Merged

Fixing some integration test failures #250

merged 3 commits into from
Jan 16, 2019

Conversation

hiranya911
Copy link
Contributor

  • Latest pytest does not allow calling fixtures as functions. Therefore we must inject them into the target functions as arguments.
  • Firestore has changed behavior wrt how non-existing docs are handled. We need to update the affected integration test case.

@hiranya911 hiranya911 requested a review from bklimt January 16, 2019 21:20
@hiranya911 hiranya911 requested a review from Feiyang1 January 16, 2019 21:37
@hiranya911 hiranya911 assigned hiranya911 and unassigned bklimt and Feiyang1 Jan 16, 2019
@hiranya911 hiranya911 merged commit 258e4ba into master Jan 16, 2019
@hiranya911 hiranya911 deleted the hkj-integ-fix branch January 16, 2019 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@bklimt bklimt Awaiting requested review from bklimt

Assignees

@hiranya911 hiranya911

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hiranya911 @Feiyang1 @bklimt @google-oss-bot