Added HttpxAsyncClient wrapper for httpx.AsyncClient and support for send_each_for_multicast_async()
#878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tring and type hints
lahirumaramba
approved these changes
May 22, 2025
| from __future__ import annotations | ||
| import logging | ||
| from typing import Any, Dict, Generator, Optional, Tuple, Union | ||
| import httpx |
There was a problem hiding this comment.
Note: let's make sure we add the new dependency to setup.py
| @@ -153,3 +165,197 @@ def __init__(self, **kwargs): | |||
|
|
|||
| def parse_body(self, resp): | |||
| return resp.json() | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
super nit: is this an extra new line?
| # The last yielded response is automatically returned by httpx's auth flow. | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
nit: let's double check these extra new lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers:
HttpxAsyncClientto wraphttpx.AsyncClientGoogleAuthCredentialFlowto_http_clientGoogleAuthCredentialFlowto correctly force a credential refreshsend_each_for_multicast_async()GoogleAuthCredentialFlowandHttpxAsyncClientsend_each_for_multicast_async()