Skip to content

GitHub Actions fix for firebase-dataconnect #6056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

dconeybe
Copy link
Contributor

No description provided.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 25, 2024

Coverage Report 1

Affected Products

  • firebase-dataconnect

    Overall coverage changed from ? (a22b1c6) to 0.00% (4a75a10) by ?.

    55 individual files with coverage change

    FilenameBase (a22b1c6)Merge (4a75a10)Diff
    ActiveQueries.kt?0.00%?
    ActiveQuery.kt?0.00%?
    ActiveQueryKey.kt?0.00%?
    ActiveQueryResult.kt?0.00%?
    Comparisons.kt?0.00%?
    ConnectorConfig.kt?0.00%?
    CoroutineExceptionHandler.kt?0.00%?
    DataConnectAuth.kt?0.00%?
    DataConnectError.kt?0.00%?
    DataConnectException.kt?0.00%?
    DataConnectGrpcClient.kt?0.00%?
    DataConnectGrpcMetadata.kt?0.00%?
    DataConnectGrpcRPCs.kt?0.00%?
    DataConnectSettings.kt?0.00%?
    DataConnectUntypedData.kt?0.00%?
    DataConnectUntypedVariables.kt?0.00%?
    DateSerializer.kt?0.00%?
    Emitters.kt?0.00%?
    FirebaseDataConnect.kt?0.00%?
    FirebaseDataConnectFactory.kt?0.00%?
    FirebaseDataConnectImpl.kt?0.00%?
    FirebaseDataConnectRegistrar.kt?0.00%?
    GeneratedConnector.kt?0.00%?
    GeneratedMutation.kt?0.00%?
    GeneratedOperation.kt?0.00%?
    GeneratedQuery.kt?0.00%?
    LiveQueries.kt?0.00%?
    LiveQuery.kt?0.00%?
    Logger.kt?0.00%?
    LogLevel.kt?0.00%?
    MutationRef.kt?0.00%?
    MutationRefImpl.kt?0.00%?
    OldQueryManager.kt?0.00%?
    OperationRef.kt?0.00%?
    OperationRefImpl.kt?0.00%?
    OptionalVariable.kt?0.00%?
    ProtoStructDecoder.kt?0.00%?
    ProtoStructEncoder.kt?0.00%?
    ProtoUtil.kt?0.00%?
    QueryExecutor.kt?0.00%?
    QueryExecutorResult.kt?0.00%?
    QueryManager.kt?0.00%?
    QueryRef.kt?0.00%?
    QueryRefImpl.kt?0.00%?
    QuerySubscription.kt?0.00%?
    QuerySubscriptionImpl.kt?0.00%?
    QuerySubscriptionInternal.kt?0.00%?
    RegisteredDataDeserialzer.kt?0.00%?
    SafeCollector.common.kt?0.00%?
    TimestampSerializer.kt?0.00%?
    TypedActiveQueries.kt?0.00%?
    TypedActiveQuery.kt?0.00%?
    TypedActiveQueryKey.kt?0.00%?
    Util.kt?0.00%?
    UUIDSerializer.kt?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/kxoRdB56N8.html

Copy link
Contributor

github-actions bot commented Jun 25, 2024

Unit Test Results

  34 files    34 suites   43s ⏱️
311 tests 311 ✔️ 0 💤 0
622 runs  622 ✔️ 0 💤 0

Results for commit 39b17c1.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 25, 2024

Size Report 1

Affected Products

  • base

    TypeBase (a22b1c6)Merge (4a75a10)Diff
    apk (aggressive)?8.80 kB? (?)
    apk (release)?9.77 kB? (?)
  • firebase-dataconnect

    TypeBase (a22b1c6)Merge (4a75a10)Diff
    aar?698 kB? (?)
    apk (aggressive)?279 kB? (?)
    apk (release)?10.6 MB? (?)
  • protolite-well-known-types

    TypeBase (a22b1c6)Merge (4a75a10)Diff
    aar?1.01 MB? (?)
    apk (aggressive)?134 kB? (?)
    apk (release)?1.68 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Sf9BcWtoty.html

@dconeybe dconeybe changed the title GitHub Actions fix GitHub Actions fix for firebase-dataconnect Jun 25, 2024
@dconeybe
Copy link
Contributor Author

I'm going to ignore the Copyright check / copyright-check (pull_request) failure for now. I've proposed a fix whereby the codegen will provide a means to include an arbitrary "header" at the top of each file, which could be used to insert the needed copyright notice (b/349231250). We'll see where this ends feature request ends up.

@dconeybe dconeybe closed this Aug 20, 2024
@dconeybe dconeybe deleted the dconeybe/GHAFix branch August 20, 2024 18:47
@firebase firebase locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants