Skip to content

Add more VertexAI unit tests #6104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Add more VertexAI unit tests #6104

merged 1 commit into from
Jul 17, 2024

Conversation

tanzimfh
Copy link
Contributor

This adds test cases to cover more of the mock response files.

Copy link
Contributor

github-actions bot commented Jul 16, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

Copy link
Contributor

github-actions bot commented Jul 16, 2024

Unit Test Results

  4 files   -      950    4 suites   - 950   3s ⏱️ - 34m 57s
49 tests  -   5 197  49 ✔️  -   5 166  0 💤  - 21  0  - 10 
98 runs   - 10 479  98 ✔️  - 10 427  0 💤  - 42  0  - 10 

Results for commit 85171ab. ± Comparison against base commit a41af7d.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

@tanzimfh tanzimfh marked this pull request as ready for review July 17, 2024 00:03
@tanzimfh tanzimfh requested review from rlazo and davidmotson July 17, 2024 00:04
@tanzimfh tanzimfh merged commit 8d5c103 into main Jul 17, 2024
30 of 31 checks passed
@tanzimfh tanzimfh deleted the tanzim/coverage branch July 17, 2024 14:04
@firebase firebase locked and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants