Skip to content

Fix CLA issues in workflows #6108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Fix CLA issues in workflows #6108

merged 3 commits into from
Jul 17, 2024

Conversation

daymxn
Copy link
Member

@daymxn daymxn commented Jul 17, 2024

Per b/353295303,

This updates our post_release_cleanup workflow to use the google-oss-bot as the signee. This should allow the workflow to pass CLA, as github-actions is not supported.

Note that while create_release does create a PR that could take advantage of this, we've chosen to keep it in a state where the CLA fails; such that the PR is not accidentally merged (as that PR should not be merged).

@daymxn daymxn requested a review from rlazo July 17, 2024 16:44
@daymxn daymxn self-assigned this Jul 17, 2024
Copy link
Contributor

github-actions bot commented Jul 17, 2024

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

Copy link
Contributor

github-actions bot commented Jul 17, 2024

Unit Test Results

     954 files  +     950       954 suites  +950   34m 46s ⏱️ + 34m 43s
  5 261 tests +  5 211    5 230 ✔️ +  5 180  21 💤 +21  10 +10 
10 607 runs  +10 507  10 555 ✔️ +10 455  42 💤 +42  10 +10 

For more details on these failures, see this check.

Results for commit 7469445. ± Comparison against base commit 3dc208c.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 17, 2024

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 17, 2024

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.20% (050cc89) to 50.22% (5d88991) by +0.02%.

    FilenameBase (050cc89)Merge (5d88991)Diff
    DefaultPersistenceManager.java74.76%75.73%+0.97%
    DoubleNode.java88.24%100.00%+11.76%
    QueryParams.java90.36%89.76%-0.60%
  • firebase-firestore

    Overall coverage changed from 45.94% (050cc89) to 45.89% (5d88991) by -0.05%.

    FilenameBase (050cc89)Merge (5d88991)Diff
    AsyncQueue.java78.11%71.14%-6.97%
  • firebase-messaging

    Overall coverage changed from 84.22% (050cc89) to 84.26% (5d88991) by +0.04%.

    FilenameBase (050cc89)Merge (5d88991)Diff
    FirebaseMessaging.java76.00%76.40%+0.40%
  • firebase-storage

    Overall coverage changed from 84.33% (050cc89) to 83.92% (5d88991) by -0.42%.

    FilenameBase (050cc89)Merge (5d88991)Diff
    NetworkRequest.java87.85%87.29%-0.55%
    StorageException.java69.09%65.45%-3.64%
    StorageTask.java83.99%83.38%-0.60%
    UploadTask.java83.17%81.52%-1.65%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/QhaNwXLpsx.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 17, 2024

Startup Time Report 1

The report is too large (122,556 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/rkwHe33sMl/index.html

@daymxn daymxn requested a review from davidmotson July 17, 2024 17:51
@daymxn daymxn enabled auto-merge (squash) July 17, 2024 18:06
@daymxn daymxn disabled auto-merge July 17, 2024 19:33
@daymxn daymxn merged commit 03c20fa into main Jul 17, 2024
167 of 174 checks passed
@daymxn daymxn deleted the daymon-use-oss-bot-for-actions branch July 17, 2024 19:33
@firebase firebase locked and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants