Skip to content

Fix makeReleaseNotes #6111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Fix makeReleaseNotes #6111

merged 1 commit into from
Jul 17, 2024

Conversation

daymxn
Copy link
Member

@daymxn daymxn commented Jul 17, 2024

Per b/353766765,

This fixes the issues with the makeReleaseNotes task when running against common. We don't publish release notes for common, but somehow made it this far without release notes disabled for it?

NO_RELEASE_CHANGE

@daymxn daymxn self-assigned this Jul 17, 2024
Copy link
Contributor

github-actions bot commented Jul 17, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@daymxn daymxn requested a review from rlazo July 17, 2024 20:53
@google-oss-bot
Copy link
Contributor

Copy link
Contributor

Unit Test Results

  50 files   -      898    50 suites   - 898   1m 21s ⏱️ - 32m 57s
  76 tests  -   5 166    76 ✔️  -   5 135  0 💤  - 21  0  - 10 
168 runs   - 10 401  168 ✔️  - 10 349  0 💤  - 42  0  - 10 

Results for commit 73bc796. ± Comparison against base commit 03c20fa.

@google-oss-bot
Copy link
Contributor

@daymxn daymxn merged commit d583311 into main Jul 17, 2024
32 checks passed
@daymxn daymxn deleted the daymon-fix-release-notes-workflow branch July 17, 2024 21:15
@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • ComponentDiscovery

    DeviceStatisticsDistributions
    oriole-32
    Percentile03c20fa8623a07DiffSignificant (?)
    p101.01 ±0.09 ms948 ±57 μs-59.2 μs (-5.9%)NO
    p251.10 ±0.1 ms1.03 ±0.06 ms-73.0 μs (-6.6%)NO
    p501.25 ±0.1 ms1.17 ±0.07 ms-82.9 μs (-6.6%)NO
    p751.47 ±0.1 ms1.39 ±0.08 ms-85.4 μs (-5.8%)NO
    p901.77 ±0.2 ms1.70 ±0.1 ms-68.2 μs (-3.9%)NO

    20 test runs in comparison
    CommitTest Runs
    03c20fa
    • 2024-07-17_19:45:08.847277_lwXG
    • 2024-07-17_19:45:08.847325_hAwJ
    • 2024-07-17_19:45:08.847336_nzzX
    • 2024-07-17_19:45:08.847344_lrHN
    • 2024-07-17_19:45:08.847352_jiLq
    • 2024-07-17_19:45:08.847361_JsXU
    • 2024-07-17_19:45:08.847369_TUoh
    • 2024-07-17_19:45:08.847376_snYt
    • 2024-07-17_19:45:08.847383_SAQc
    • 2024-07-17_19:45:08.847390_BOcf
    8623a07
    • 2024-07-17_21:07:22.653097_vLNT
    • 2024-07-17_21:07:22.653139_wqEN
    • 2024-07-17_21:07:22.653151_Igol
    • 2024-07-17_21:07:22.653160_QuWA
    • 2024-07-17_21:07:22.653168_pDCb
    • 2024-07-17_21:07:22.653175_yMFM
    • 2024-07-17_21:07:22.653192_JaKM
    • 2024-07-17_21:07:22.653200_jjWx
    • 2024-07-17_21:07:22.653206_BAUv
    • 2024-07-17_21:07:22.653213_MFsr
    redfin-30
    Percentile03c20fa8623a07DiffSignificant (?)
    p10863 ±19 μs872 ±26 μs+9.08 μs (+1.1%)NO
    p25900 ±21 μs912 ±27 μs+12.2 μs (+1.4%)NO
    p50974 ±26 μs987 ±25 μs+13.7 μs (+1.4%)NO
    p751.20 ±0.07 ms1.28 ±0.09 ms+83.6 μs (+7.0%)NO
    p901.67 ±0.2 ms1.78 ±0.2 ms+109 μs (+6.5%)NO

    20 test runs in comparison
    CommitTest Runs
    03c20fa
    • 2024-07-17_19:45:08.847277_lwXG
    • 2024-07-17_19:45:08.847325_hAwJ
    • 2024-07-17_19:45:08.847336_nzzX
    • 2024-07-17_19:45:08.847344_lrHN
    • 2024-07-17_19:45:08.847352_jiLq
    • 2024-07-17_19:45:08.847361_JsXU
    • 2024-07-17_19:45:08.847369_TUoh
    • 2024-07-17_19:45:08.847376_snYt
    • 2024-07-17_19:45:08.847383_SAQc
    • 2024-07-17_19:45:08.847390_BOcf
    8623a07
    • 2024-07-17_21:07:22.653097_vLNT
    • 2024-07-17_21:07:22.653139_wqEN
    • 2024-07-17_21:07:22.653151_Igol
    • 2024-07-17_21:07:22.653160_QuWA
    • 2024-07-17_21:07:22.653168_pDCb
    • 2024-07-17_21:07:22.653175_yMFM
    • 2024-07-17_21:07:22.653192_JaKM
    • 2024-07-17_21:07:22.653200_jjWx
    • 2024-07-17_21:07:22.653206_BAUv
    • 2024-07-17_21:07:22.653213_MFsr
  • Firebase

    DeviceStatisticsDistributions
    oriole-32
    Percentile03c20fa8623a07DiffSignificant (?)
    p107.21 ±0.7 ms6.66 ±0.1 ms-554 μs (-7.7%)NO
    p257.65 ±0.9 ms7.01 ±0.2 ms-639 μs (-8.4%)NO
    p508.41 ±1 ms7.53 ±0.2 ms-877 μs (-10.4%)NO
    p759.20 ±2 ms8.26 ±0.3 ms-941 μs (-10.2%)NO
    p9010.2 ±2 ms9.26 ±0.3 ms-973 μs (-9.5%)NO

    20 test runs in comparison
    CommitTest Runs
    03c20fa
    • 2024-07-17_19:45:08.847277_lwXG
    • 2024-07-17_19:45:08.847325_hAwJ
    • 2024-07-17_19:45:08.847336_nzzX
    • 2024-07-17_19:45:08.847344_lrHN
    • 2024-07-17_19:45:08.847352_jiLq
    • 2024-07-17_19:45:08.847361_JsXU
    • 2024-07-17_19:45:08.847369_TUoh
    • 2024-07-17_19:45:08.847376_snYt
    • 2024-07-17_19:45:08.847383_SAQc
    • 2024-07-17_19:45:08.847390_BOcf
    8623a07
    • 2024-07-17_21:07:22.653097_vLNT
    • 2024-07-17_21:07:22.653139_wqEN
    • 2024-07-17_21:07:22.653151_Igol
    • 2024-07-17_21:07:22.653160_QuWA
    • 2024-07-17_21:07:22.653168_pDCb
    • 2024-07-17_21:07:22.653175_yMFM
    • 2024-07-17_21:07:22.653192_JaKM
    • 2024-07-17_21:07:22.653200_jjWx
    • 2024-07-17_21:07:22.653206_BAUv
    • 2024-07-17_21:07:22.653213_MFsr
    redfin-30
    Percentile03c20fa8623a07DiffSignificant (?)
    p108.92 ±0.3 ms8.99 ±0.2 ms+71.2 μs (+0.8%)NO
    p259.22 ±0.4 ms9.31 ±0.2 ms+89.2 μs (+1.0%)NO
    p509.68 ±0.4 ms9.81 ±0.3 ms+123 μs (+1.3%)NO
    p7510.5 ±0.5 ms10.7 ±0.4 ms+246 μs (+2.3%)NO
    p9011.8 ±0.7 ms12.1 ±0.7 ms+304 μs (+2.6%)NO

    20 test runs in comparison
    CommitTest Runs
    03c20fa
    • 2024-07-17_19:45:08.847277_lwXG
    • 2024-07-17_19:45:08.847325_hAwJ
    • 2024-07-17_19:45:08.847336_nzzX
    • 2024-07-17_19:45:08.847344_lrHN
    • 2024-07-17_19:45:08.847352_jiLq
    • 2024-07-17_19:45:08.847361_JsXU
    • 2024-07-17_19:45:08.847369_TUoh
    • 2024-07-17_19:45:08.847376_snYt
    • 2024-07-17_19:45:08.847383_SAQc
    • 2024-07-17_19:45:08.847390_BOcf
    8623a07
    • 2024-07-17_21:07:22.653097_vLNT
    • 2024-07-17_21:07:22.653139_wqEN
    • 2024-07-17_21:07:22.653151_Igol
    • 2024-07-17_21:07:22.653160_QuWA
    • 2024-07-17_21:07:22.653168_pDCb
    • 2024-07-17_21:07:22.653175_yMFM
    • 2024-07-17_21:07:22.653192_JaKM
    • 2024-07-17_21:07:22.653200_jjWx
    • 2024-07-17_21:07:22.653206_BAUv
    • 2024-07-17_21:07:22.653213_MFsr
  • Runtime

    DeviceStatisticsDistributions
    oriole-32
    Percentile03c20fa8623a07DiffSignificant (?)
    p106.03 ±0.7 ms5.55 ±0.1 ms-481 μs (-8.0%)NO
    p256.40 ±0.9 ms5.81 ±0.1 ms-587 μs (-9.2%)NO
    p507.04 ±1 ms6.25 ±0.1 ms-791 μs (-11.2%)NO
    p757.69 ±1 ms6.85 ±0.2 ms-842 μs (-10.9%)NO
    p908.58 ±2 ms7.76 ±0.3 ms-815 μs (-9.5%)NO

    20 test runs in comparison
    CommitTest Runs
    03c20fa
    • 2024-07-17_19:45:08.847277_lwXG
    • 2024-07-17_19:45:08.847325_hAwJ
    • 2024-07-17_19:45:08.847336_nzzX
    • 2024-07-17_19:45:08.847344_lrHN
    • 2024-07-17_19:45:08.847352_jiLq
    • 2024-07-17_19:45:08.847361_JsXU
    • 2024-07-17_19:45:08.847369_TUoh
    • 2024-07-17_19:45:08.847376_snYt
    • 2024-07-17_19:45:08.847383_SAQc
    • 2024-07-17_19:45:08.847390_BOcf
    8623a07
    • 2024-07-17_21:07:22.653097_vLNT
    • 2024-07-17_21:07:22.653139_wqEN
    • 2024-07-17_21:07:22.653151_Igol
    • 2024-07-17_21:07:22.653160_QuWA
    • 2024-07-17_21:07:22.653168_pDCb
    • 2024-07-17_21:07:22.653175_yMFM
    • 2024-07-17_21:07:22.653192_JaKM
    • 2024-07-17_21:07:22.653200_jjWx
    • 2024-07-17_21:07:22.653206_BAUv
    • 2024-07-17_21:07:22.653213_MFsr
    redfin-30
    Percentile03c20fa8623a07DiffSignificant (?)
    p107.88 ±0.3 ms7.93 ±0.2 ms+45.1 μs (+0.6%)NO
    p258.15 ±0.3 ms8.18 ±0.2 ms+29.9 μs (+0.4%)NO
    p508.53 ±0.4 ms8.59 ±0.3 ms+64.7 μs (+0.8%)NO
    p759.10 ±0.5 ms9.20 ±0.4 ms+107 μs (+1.2%)NO
    p9010.0 ±0.5 ms10.2 ±0.6 ms+118 μs (+1.2%)NO

    20 test runs in comparison
    CommitTest Runs
    03c20fa
    • 2024-07-17_19:45:08.847277_lwXG
    • 2024-07-17_19:45:08.847325_hAwJ
    • 2024-07-17_19:45:08.847336_nzzX
    • 2024-07-17_19:45:08.847344_lrHN
    • 2024-07-17_19:45:08.847352_jiLq
    • 2024-07-17_19:45:08.847361_JsXU
    • 2024-07-17_19:45:08.847369_TUoh
    • 2024-07-17_19:45:08.847376_snYt
    • 2024-07-17_19:45:08.847383_SAQc
    • 2024-07-17_19:45:08.847390_BOcf
    8623a07
    • 2024-07-17_21:07:22.653097_vLNT
    • 2024-07-17_21:07:22.653139_wqEN
    • 2024-07-17_21:07:22.653151_Igol
    • 2024-07-17_21:07:22.653160_QuWA
    • 2024-07-17_21:07:22.653168_pDCb
    • 2024-07-17_21:07:22.653175_yMFM
    • 2024-07-17_21:07:22.653192_JaKM
    • 2024-07-17_21:07:22.653200_jjWx
    • 2024-07-17_21:07:22.653206_BAUv
    • 2024-07-17_21:07:22.653213_MFsr
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile03c20fa8623a07DiffSignificant (?)
    p10205 ±13 ms205 ±5 ms+890 μs (+0.4%)NO
    p25213 ±18 ms211 ±3 ms-2.35 ms (-1.1%)NO
    p50226 ±29 ms218 ±4 ms-7.73 ms (-3.4%)NO
    p75238 ±39 ms227 ±5 ms-11.0 ms (-4.6%)NO
    p90247 ±41 ms236 ±5 ms-10.4 ms (-4.2%)NO

    20 test runs in comparison
    CommitTest Runs
    03c20fa
    • 2024-07-17_19:45:08.847277_lwXG
    • 2024-07-17_19:45:08.847325_hAwJ
    • 2024-07-17_19:45:08.847336_nzzX
    • 2024-07-17_19:45:08.847344_lrHN
    • 2024-07-17_19:45:08.847352_jiLq
    • 2024-07-17_19:45:08.847361_JsXU
    • 2024-07-17_19:45:08.847369_TUoh
    • 2024-07-17_19:45:08.847376_snYt
    • 2024-07-17_19:45:08.847383_SAQc
    • 2024-07-17_19:45:08.847390_BOcf
    8623a07
    • 2024-07-17_21:07:22.653097_vLNT
    • 2024-07-17_21:07:22.653139_wqEN
    • 2024-07-17_21:07:22.653151_Igol
    • 2024-07-17_21:07:22.653160_QuWA
    • 2024-07-17_21:07:22.653168_pDCb
    • 2024-07-17_21:07:22.653175_yMFM
    • 2024-07-17_21:07:22.653192_JaKM
    • 2024-07-17_21:07:22.653200_jjWx
    • 2024-07-17_21:07:22.653206_BAUv
    • 2024-07-17_21:07:22.653213_MFsr
    redfin-30
    Percentile03c20fa8623a07DiffSignificant (?)
    p10243 ±5 ms267 ±5 ms+24.0 ms (+9.9%)MAYBE
    p25249 ±5 ms272 ±6 ms+23.2 ms (+9.3%)MAYBE
    p50255 ±6 ms279 ±6 ms+24.2 ms (+9.5%)MAYBE
    p75263 ±6 ms288 ±7 ms+25.3 ms (+9.6%)MAYBE
    p90272 ±5 ms301 ±10 ms+29.6 ms (+10.9%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    03c20fa
    • 2024-07-17_19:45:08.847277_lwXG
    • 2024-07-17_19:45:08.847325_hAwJ
    • 2024-07-17_19:45:08.847336_nzzX
    • 2024-07-17_19:45:08.847344_lrHN
    • 2024-07-17_19:45:08.847352_jiLq
    • 2024-07-17_19:45:08.847361_JsXU
    • 2024-07-17_19:45:08.847369_TUoh
    • 2024-07-17_19:45:08.847376_snYt
    • 2024-07-17_19:45:08.847383_SAQc
    • 2024-07-17_19:45:08.847390_BOcf
    8623a07
    • 2024-07-17_21:07:22.653097_vLNT
    • 2024-07-17_21:07:22.653139_wqEN
    • 2024-07-17_21:07:22.653151_Igol
    • 2024-07-17_21:07:22.653160_QuWA
    • 2024-07-17_21:07:22.653168_pDCb
    • 2024-07-17_21:07:22.653175_yMFM
    • 2024-07-17_21:07:22.653192_JaKM
    • 2024-07-17_21:07:22.653200_jjWx
    • 2024-07-17_21:07:22.653206_BAUv
    • 2024-07-17_21:07:22.653213_MFsr

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/VHAqOcjwxX/index.html

@firebase firebase locked and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants