[DRAFT] Enable to run functional tests on Intel Sapphire Rapids #5067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bindings for ARCH_REQ_XCOMP_GUEST_PERM and ARCH_XCOMP_TILEDATA are required to enable Intel AMX's XTILEDATA for XSAVE. Note that the required bits were added in kernel v6.4+. Signed-off-by: Takahiro Itazuri <[email protected]>
Eq and PartialEq are not necessary for KvmError, rather disallows me to add error variants wrapping std::io::Error to handle syscall errors. Signed-off-by: Takahiro Itazuri <[email protected]>
Intel AMX was introduced in Intel Sapphire Rapids and stands for Advanced Matrix Extensions that accelerates deep learning and artificial intelligence workloads. Since it requires larger area to save its state, the TILEDATA feature is disabled by default. We enable it by default because it can be disabled via CPU template. Otherwise, kernels prior to v6.4 have a bug where KVM_GET_SUPPORTED_CPUID returns an inconsistent state of TILECFG enabled but TILEDATA disabled by default, causing guest's #GP fault on xsetbv instruction. Signed-off-by: Takahiro Itazuri <[email protected]>
We have to skip the snapshot restore performance test on Intel Sapphire Rappids for now, since a new KVM API (KVM_GET_XSAVE2) that has not been supported yet in rust-vmm kvm-ioctls, although it will be supported soon. To skip on Intel Sapphire Rapids, the python testing framework has to be able to detect Intel Sapphire Rapids. Signed-off-by: Takahiro Itazuri <[email protected]>
To support the snapshot restore feature, a new KVM API (KVM_GET_XSAVE2) is required but it has not been supported yet in rust-vmm kvm-ioctls. Until supported, skip the snapshot restore performance test for now. Signed-off-by: Takahiro Itazuri <[email protected]>
CPU features that lscpu command shows can vary depending on guest kernels. Signed-off-by: Takahiro Itazuri <[email protected]>
Some new features are added. Signed-off-by: Takahiro Itazuri <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5067 +/- ##
==========================================
- Coverage 83.19% 83.17% -0.02%
==========================================
Files 247 247
Lines 26641 26682 +41
==========================================
+ Hits 22163 22194 +31
- Misses 4478 4488 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
close in favor of #5084 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR must be merged after:
Changes
...
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.