vmm: warn instead of bailing out on unexpected subleaf for leaf 0xB. #5231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 68e7a4c. Signed-off-by: Takahiro Itazuri <[email protected]>
zulinx86
added
the
Status: Awaiting review
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5231 +/- ##
==========================================
+ Coverage 82.89% 82.94% +0.04%
==========================================
Files 250 250
Lines 26965 26966 +1
==========================================
+ Hits 22353 22367 +14
+ Misses 4612 4599 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KVM no longer returns any subleaves greater than 0. The patch was merged in v6.2 and backported to v5.10. So for all our supported kernels, subleaves >= 2 should not be included [1]. However, we intentionally leave Firecracker not fail for unsupported kernels to keep working. Note that we can detect KVM regression thanks to the test that compares a fingerprint with its baseline. So prints a warning message without bailing out. [1]: torvalds/linux@45e966f Signed-off-by: Takahiro Itazuri <[email protected]>
Manciukic
approved these changes
May 29, 2025
JackThomson2
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Prints a warning message instead of erroring out on unexpected subleaf detected for CPUID leaf 0xB.
Reason
Fixes #5213
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
[ ] I have updated any relevant documentation (both in code and in the docs)in the PR.
[ ] I have mentioned all user-facing changes inCHANGELOG.md.[ ] When making API changes, I have followed theRunbook for Firecracker API changes.
integration tests.
[ ] I have linked an issue to every newTODO.rust-vmm.