Fix documentation build #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
tony-iqlusion
added a commit
to cometbft/tendermint-rs
that referenced
this pull request
Mar 10, 2023
Breaks the docs build. See fizyk20/generic-array#133
tony-iqlusion
added a commit
to cometbft/tendermint-rs
that referenced
this pull request
Mar 10, 2023
The `generic-array` crate's docs won't build without this, which breaks the docs build in CI
Co-authored-by: Tony Arcieri (iqlusion) <[email protected]>
|
Hi @fjarri, do you have plans to get this over the line? We seem to be hitting some nightly docs error on CI cometbft/tendermint-rs#1285 (comment) and would love to resolve. Let us know! Thanks!! |
|
Unfortunately I do not have control over this repo. |
|
oops my bad - cc @fizyk20 |
|
Backported this to 0.14.7 |
romac
added a commit
to cometbft/tendermint-rs
that referenced
this pull request
Apr 4, 2023
* Bump `ed25519` => v2; `k256` => v0.13; `signature` => v2 Bumps all of the above dependencies to their latest versions, which use the new `signature` v2 release: RustCrypto/traits#1211 * Add `patch.crates-io` for fizyk20/generic-array#133 The `generic-array` crate's docs won't build without this, which breaks the docs build in CI * Remove workaround for docs build in CI * Pin docs build to nightly-2023-03-01 It fails on newer versions: https://github.com/informalsystems/tendermint-rs/actions/runs/4602897393/jobs/8132365869?pr=1285 * Add changelog entry --------- Co-authored-by: Romain Ruetschi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc_cfganddoc_auto_cfgduring documentation build, to make the "available on crate feature <...>" label actually appear.doc_auto_cfgin particular figures out the placement of such labels automatically, so I could remove it from theZeroizeimpl.impl_zeroize.rscargo fmtrun (also thereorder_imported_namesoption inrustfmt.tomlseems to have been deprecated)You can test it locally by running
env RUSTDOCFLAGS="--cfg docsrs" cargo +nightly doc --all-features.Currently in docs.rs:
Built with this PR:
