-
Notifications
You must be signed in to change notification settings - Fork 13
prefab fab aware invdes notebook #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tylerflex! The results are very exciting!
I have only a few minor comments and typos:
- Here, "which has n=4 output waveguides", it seems
n
is a variable, but it is not present on the code. It is not critical, but maybe you could explicitly define it as the number of channel wavelengths. - Another cosmetic comment regards the use of "Static Simulation". In some notebooks we have "Base Simulation" and other ones use "Static Components". Maybe we should unify these names.
- "We'll use
tidy3d
'sModeSolver
" -> "We'll useTidy3D
'sModeSolver
" - In [11], the chart legends overlap the curves. It is not possible to visualize the modes.
- It seems something is missing here "number of pixels in x and y staticd on our design region resolution"
- "Our objective whenn looking" -> "Our objective when looking"
- "which we will feed to the optimizer.th" -> "which we will feed to the optimizer."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good demo. If similar processes can be done for foundry fab that would be a great pusher for industry adaptation of inverse design.
When external libraries are needed, I think we typically comment out the pip install
part so it can cut down the length of the page a bit.
The capitalization of the headers is a bit inconsistent. Could you double check?
A few typos in addition to Emerson's comment:
- "the fabrication-predicted transmission spectra gets distorted" -> "the fabrication-predicted transmission spectra get distorted".
- "input light of different wavelengths get directed" -> "input light of different wavelengths gets directed".
- "on an SiO2 substrate" -> "on a SiO2 substrate".
- "components that dont change" -> "components that don't change".
- "specificiation" -> "specification".
- "supressed" -> "suppressed".
Do you need me to add a schematic and metadata to the notebook?
thanks @tomflexcompute , I just made all changes. If you could add the metadadta and schematic if you get to it, that would be great. appreciate it |
No problem will get to it either later today or early tomorrow. |
Added schematic image and metadata
@tylerflex feel free to check the image and metadata that were just added. |
looks great, thanks tom! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks super nice, don't have anything to add to the previous reviews. Thanks a lot!
@Dusandinho
Introduces prefab-flex compute colab 2.0. This time we optimize the WDM but with pre-fab prediction built into the optimization loop, so we end up simulating "real" devices. The final results show that the design is robust to fabrication variation compared to the one without any prefab in the loop. This is part of a concept called "FAID" or "Fabrication Aware Inverse Design"