Skip to content

feat: #1416 Added missing TextField properties to FormBuilderTextField #1417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alex-medinsh
Copy link
Contributor

Connection with issue(s)

Close #1416

Solution description

Added the missing properties to FormBuilderTextField.
Skipped toolbarOptions since it is deprecated for a long time.
Skipped onChanged since FormBuilder handles it internally.

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

@deandreamatias deandreamatias changed the title Added missing TextField properties to FormBuilderTextField feat: Added missing TextField properties to FormBuilderTextField Aug 11, 2024
@deandreamatias deandreamatias changed the title feat: Added missing TextField properties to FormBuilderTextField feat: #1416 Added missing TextField properties to FormBuilderTextField Aug 11, 2024
Copy link

codecov bot commented Aug 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.90%. Comparing base (6a92730) to head (94a69cb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1417   +/-   ##
=======================================
  Coverage   87.90%   87.90%           
=======================================
  Files          21       21           
  Lines         769      769           
=======================================
  Hits          676      676           
  Misses         93       93           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deandreamatias deandreamatias merged commit 5a4ee48 into flutter-form-builder-ecosystem:main Aug 11, 2024
6 of 8 checks passed
@alex-medinsh alex-medinsh mentioned this pull request Aug 11, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FormBuilderTextField]: Add missing TextField properties.
2 participants